Postgres db helm charts #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbuenodevsuse
force-pushed
the
postgres-db-helm-charts
branch
from
14d2411 to
8554a9d
Compare
rtamalin
reviewed
Jul 29, 2024
rtamalin
reviewed
Jul 29, 2024
| targetCPUUtilizationPercentage: 80 | ||
| # targetMemoryUtilizationPercentage: 80 | ||
|
|
||
| # OpenPlatform |
There was a problem hiding this comment.
Potentially instead of commenting this out, could we make it conditionally generated based upon a setting that we can override that defaults to disabled for now?
There was a problem hiding this comment.
Note also that we will potentially have all 3 DB envs served by this one postgres instance, i.e staging (caching), operational and telemetry
There was a problem hiding this comment.
That's a good suggestion. I'll have it addressed in a follow-up PR, together with k3s local dev environment setup.
rtamalin
reviewed
Jul 29, 2024
rtamalin
reviewed
Jul 29, 2024
rtamalin
reviewed
Jul 29, 2024
rtamalin
approved these changes
Jul 29, 2024
|
LGTM - we can address any other changes in follow up PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding postgres helm charts.
Reorganizing helm charts directories.