Fix proposal: ioutil deprecation #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wabri
force-pushed
the
fix/ioutil_deprecation
branch
from
e505960 to
e4872a3
Compare
Wabri
force-pushed
the
fix/ioutil_deprecation
branch
from
e4872a3 to
e536a30
Compare
angelabriel
requested changes
Aug 21, 2024
There was a problem hiding this comment.
Would be nice, if we can get this PR in a state for merging. But this means we need to fix system/file_test.go as discussed in #127 (comment) to get the unit tests working again.
- [go#40025](golang/go#42025) - [go#40026](golang/go#42026)
Wabri
force-pushed
the
fix/ioutil_deprecation
branch
from
e536a30 to
78f05aa
Compare
angelabriel
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor(ioutil): ioutil is deprecated after 1.16
This pr is dependent from #127, I'll move to pr ready from draft when that pr is merged