Biglots #21
Open
Biglots #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbologna
reviewed
Dec 21, 2020
|
|
||
| <users> | ||
| <user | ||
| password="$1$xyz$dCB0XV.AZGZOsJNJwnQVi0" |
There was a problem hiding this comment.
Are you sure you want to commit a hashed password for the two users you created?
aaannz
requested changes
Jan 14, 2021
There was a problem hiding this comment.
This is severely modifying base Graphical7 template. I am not sure if you really wanted to submit a PR to master repo or some separate branch but I cannot merge it it current form.
If you really want this to be in master repo, then please create new image name folder for it.
mbologna
suggested changes
Jan 14, 2021
There was a problem hiding this comment.
I think there are some things to be addressed:
- The directory in which this AutoYAST profile lives (please change it to something else than
POS_Image-Graphical) - The passwords for the two users you created should be specified in the README
- The README link template points to github.com/dvosburg instead of SUSE/manager-build-profile
made it custom a bit
Updated group
Fix users
Changed the image type from pxe to oem with qcow2
Added dracut-kiwi-oem-repart
disk size
Fixed for our purposes
Update version following changes to image.sh
Added gnome pattern package
|
@dvosburg is this still relevant or can we close it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.