Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add figure titles to make images easier to find #358

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Conversation

tahliar
Copy link
Collaborator

@tahliar tahliar commented Nov 17, 2023

PR creator: Description

Having figure titles for all images means I can Ctrl-F for "Figure" to check all images that are in use in the doc set.

I also added descriptions where these were missing for images I added titles to.

PR creator: Which product versions do the changes apply to?

When opening a PR, check all versions of the documentation that your PR applies to.

  • SLE-HA 15
    • 15 next (current main, no backport necessary)
    • 15 SP5
    • 15 SP4
    • 15 SP3
    • 15 SP2
    • 15 SP1
  • SLE-HA 12
    • 12 SP5
    • 12 SP4

PR reviewer only: Have all backports been applied?

The doc team member merging your PR will take care of backporting to older documents.
When opening a PR, do not set the following check box.

  • all necessary backports are done

Copy link
Contributor

@dariavladykina dariavladykina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just an itty-bitty nitpick.

@tahliar tahliar merged commit 0df5a20 into main Nov 21, 2023
4 checks passed
@tahliar tahliar deleted the add-figure-titles branch November 21, 2023 01:42
tahliar added a commit that referenced this pull request Nov 21, 2023
* Add figure titles to make images easier to find

* Update xml/ha_resource_constraints.xml

Co-authored-by: Daria Vladykina <[email protected]>

---------

Co-authored-by: Daria Vladykina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants