[WIP] test case added for kubectl container #710
Conversation
rcmadhankumar
changed the title
| ("1.30", ("15.7")), | ||
| ("1.29", ("tumbleweed")), | ||
| ("1.30", ("tumbleweed")), | ||
| ("1.31", ("tumbleweed")), |
There was a problem hiding this comment.
The second element is not a tuple, you're missing the trailing comma:
>>> type(("foo"))
<class 'str'>
>>> type(("foo",))
<class 'tuple'>
That's also why the whole CI is red.
| ("1.30", ("15.7")), | |
| ("1.29", ("tumbleweed")), | |
| ("1.30", ("tumbleweed")), | |
| ("1.31", ("tumbleweed")), | |
| ("1.30", ("15.7",)), | |
| ("1.29", ("tumbleweed",)), | |
| ("1.30", ("tumbleweed",)), | |
| ("1.31", ("tumbleweed",)), |
| cluster_name = os.getenv("K3S_CLUSTER_NAME") | ||
| control_plane = "k3d-" + cluster_name + "-server-0" | ||
| host.run_expect([0], f"k3d kubeconfig get {cluster_name} > kubeconfig") |
There was a problem hiding this comment.
Please try to make use of something entirely container based without requiring external binaries. We don't have k3d available on all openQA workers and getting it in there will be a major headache for QA. A k3s based container would be much preferred tbh
There was a problem hiding this comment.
in theory, you could make an API call to request this, all you might need is curl and a valid token.
| @@ -400,6 +402,13 @@ jobs: | |||
| echo -e "$(getent ahostsv4 $host | grep STREAM | cut -d' ' -f1 | head -n 1)\t$host" | sudo tee -a /etc/hosts | |||
| done | |||
|
|
|||
| - uses: AbsaOSS/k3d-action@v2 | |||
There was a problem hiding this comment.
Do we care about actions and where they come from? Since this is a 3rd party repo it could disappear one day.
This action could in theory be just a rancher/k3d container with custom arguments, because it seems that all this action does is download k3d and start a server.
| cluster_name = os.getenv("K3S_CLUSTER_NAME") | ||
| control_plane = "k3d-" + cluster_name + "-server-0" | ||
| host.run_expect([0], f"k3d kubeconfig get {cluster_name} > kubeconfig") |
There was a problem hiding this comment.
in theory, you could make an API call to request this, all you might need is curl and a valid token.
[CI:TOXENVS] kubectl