feat(packages/sui-logger): Add tracing to 300x and 400x pages #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcbenito
requested review from
sui-bot,
kikoruiz,
andresz1 and
carlosvillu
as code owners
jordevo
reviewed
Dec 20, 2024
| @@ -28,7 +28,7 @@ export class DataDogLogger extends Writable { | |||
| method: req ? req.method : '-' // eslint-disable-line | |||
| } | |||
|
|
|||
| if (!req || statusFamily === '4xx' || statusFamily === '3xx') { | |||
There was a problem hiding this comment.
do we know the reason why these status code families were an exception in the first place...?
There was a problem hiding this comment.
As far as @carlosvillu and @andresz1 told me, the reason should be the increase of tags.
Adding this PR we will increase the number of tags for the server.request metric as much as routerUrls we have in the project ( x2, one for 3xx and the other for 4xx) In fotocasa for example it means add 80 tags
There was a problem hiding this comment.
On the other hand we get the option to monitor increases/decreases (anomalies) of 3xx and 4xx.
For example, that days we cannot create a monitor to detect an increase of 400x errors for a specific page. Only global
andresz1
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now, in datadog, we are receiving the 4xx and 3xx without URL. The idea is to add the url path ( as same way as 2xx and 500)
Adding this PR we will increase the number of tags for the server.request metric as much as routerUrls we have in the project ( x2, one for 3xx and the other for 4xx) In fotocasa for example it means add 80 tags
Related Issue
Example
Monitoring for 4xx or 3xx
Monitoring for 5xx and 2xx