roles, adding default domain password policy management #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlavu
force-pushed
the
roles-password-policy
branch
2 times, most recently
from
6ce3b2f to
a0156fe
Compare
danlavu
force-pushed
the
roles-password-policy
branch
6 times, most recently
from
e63f374 to
fe86c02
Compare
aplopez
reviewed
Dec 10, 2024
| super().__init__(role) | ||
|
|
||
| def complexity(self, enable: bool) -> ADPasswordPolicy: | ||
| """ |
There was a problem hiding this comment.
I'm not sure whether this documentation is needed if it is already present in the superclass.
There was a problem hiding this comment.
I'm going to change this back to a @property , so it's not instantiated with every call, I forgot about that and I will put usage examples in that docstring.
There was a problem hiding this comment.
Making this function a property will not allow you to return a ADPasswordPolicy object (self) in order to chain method invocations. I have nothing against it, but it doesn't align with the rest of your code. Do as you want.
There was a problem hiding this comment.
Ah that explains something I didn't quite understand. I made this decision change because it wouldn't automatically instantiate the object, but I do want the other behavior so I will change this back.
| "minclasses": (self.cli.option.VALUE, 5), | ||
| "priority": (self.cli.option.VALUE, 1), | ||
| } | ||
| self._add(attrs) |
There was a problem hiding this comment.
Why are you calling self._add() here but self._modify() in the else section?
There was a problem hiding this comment.
It's the way the command is constructed. IPARole._add is ipa pwpolicy add , while IPARole._modify is ipa pwpolicy modify. If enabled, we are adding the values that don't exist, to disable it, we are modifying the existing values.
There was a problem hiding this comment.
What happens if the test has code like this?
ipp = IPAPasswordPolicy(...)
...
ipp.complexity(true)
...
ipp.complexity(false)
...
ipp.complexity(true)
There was a problem hiding this comment.
Nice catch, I'll go ahead and add something to check to see if the attribute exists and decide which function to use.
danlavu
force-pushed
the
roles-password-policy
branch
from
fe86c02 to
41c9628
Compare
danlavu
force-pushed
the
roles-password-policy
branch
4 times, most recently
from
3eab089 to
13eef9b
Compare
|
The tests are passing locally. |
added 5 commits
December 11, 2024 17:39
danlavu
force-pushed
the
roles-password-policy
branch
from
13eef9b to
10992d0
Compare
danlavu
commented
Dec 18, 2024
| "minclasses": (self.cli.option.VALUE, 5), | ||
| "priority": (self.cli.option.VALUE, 1), | ||
| } | ||
| self._add(attrs) |
There was a problem hiding this comment.
Nice catch, I'll go ahead and add something to check to see if the attribute exists and decide which function to use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests PR, SSSD/sssd#7728
This PR is larger than I expected.
misc.py
authentication.py
roles/ad.py, roles/ipa.py, roles/samba.py, roles/ldap.py
roles/generic.py