Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCSAT: more decision hints for integer variables #511

Merged
merged 5 commits into from
Apr 23, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions src/mcsat/nra/nra_plugin.c
Original file line number Diff line number Diff line change
Expand Up @@ -860,6 +860,7 @@ void nra_plugin_process_unit_constraint(nra_plugin_t* nra, trail_token_t* prop,
}
lp_value_destruct(&v);
}

if (!x_in_conflict && !trail_has_value(nra->ctx->trail, x)) {
const lp_feasibility_set_t *feasible_set = feasible_set_db_get(nra->feasible_set_db, x);
if (lp_feasibility_set_is_point(feasible_set)) {
Expand All @@ -880,6 +881,32 @@ void nra_plugin_process_unit_constraint(nra_plugin_t* nra, trail_token_t* prop,
}
}
lp_value_destruct(&x_value);

} else if (variable_db_is_int(nra->ctx->var_db, x) &&
!lp_feasibility_set_is_full(feasible_set)) {
lp_interval_t x_interval;
lp_interval_construct_full(&x_interval); // [-inf, +inf]
// now we over-approx the feasible set using an interval and
// the result is stored in x_interval, e.g., [1.6, 2.5]
// union [4.2, 4.6] is approximated by [1.6, 4.6].
feasible_set_db_approximate_value(nra->feasible_set_db, x, &x_interval);
int interval_dist = lp_interval_size_approx(&x_interval);
if (interval_dist <= 1) {
// interval distance of an interval [a, b] is defined as log2(|b - a|) + 1.
// interval distance 1 means that the absolute log2 distance
// between the upper and lower bound is 1.
// Consider the the interval [3,4], the interval distance is 1, and has
// two integer value: 3 and 4.
// Now consider the interval [5.5, 6.1], the interval distance is 0 and
// has one integer value: 6. log2(.6) = log2(6) - log2(10).
// Here, we are hinting to the main mcsat solver to decide on this variable
// as the possible integer values for the variable is highly likely one.
if (ctx_trace_enabled(nra->ctx, "nra::propagate")) {
ctx_trace_printf(nra->ctx, "nra: hinting variable = %d\n", x);
}
nra->ctx->hint_next_decision(nra->ctx, x);
}
lp_interval_destruct(&x_interval);
}
}
}
Expand Down
Loading