Skip to content

Commit

Permalink
Removed interval approx for hinting.
Browse files Browse the repository at this point in the history
  • Loading branch information
Thomas Hader committed Oct 9, 2024
1 parent 12c380a commit f2bbb33
Showing 1 changed file with 0 additions and 27 deletions.
27 changes: 0 additions & 27 deletions src/mcsat/nra/nra_plugin.c
Original file line number Diff line number Diff line change
Expand Up @@ -814,33 +814,6 @@ void nra_plugin_process_unit_constraint(nra_plugin_t* nra, trail_token_t* prop,
}
nra->ctx->hint_next_decision(nra->ctx, x);
}

// turning this on for reals as well
} else if (!lp_feasibility_set_is_full(feasible_set) && lp_value_is_integer(&x_value)) {
lp_interval_t x_interval;
lp_interval_construct_full(&x_interval); // [-inf, +inf]
// now we over-approx the feasible set using an interval and
// the result is stored in x_interval, e.g., [1.6, 2.5]
// union [4.2, 4.6] is approximated by [1.6, 4.6].
feasible_set_db_approximate_value(nra->feasible_set_db, x, &x_interval);
int interval_dist = lp_interval_size_approx(&x_interval);
if (interval_dist <= 1) {
// interval distance of an interval [a, b] is defined as log2(|b - a|) + 1.
// interval distance 1 means that the absolute log2 distance
// between the upper and lower bound is 1.
// Consider the interval [3,4], the interval distance is 1, and has
// two integer value: 3 and 4.
// Now consider the interval [5.5, 6.1], the interval distance is 0 and
// has one integer value: 6. log2(.6) = log2(6) - log2(10).
// Here, we are hinting to the main mcsat solver to decide on this variable
// as the possible integer values for the variable is highly likely one.
// it is good idea to decide on this variable (integers or reals)
if (ctx_trace_enabled(nra->ctx, "nra::propagate")) {
ctx_trace_printf(nra->ctx, "nra: hinting variable = %d\n", x);
}
nra->ctx->hint_next_decision(nra->ctx, x);
}
lp_interval_destruct(&x_interval);
}
}
lp_value_destruct(&x_value);
Expand Down

0 comments on commit f2bbb33

Please sign in to comment.