Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update pillarbox version to 1.4.3 #25

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Conversation

jboix
Copy link
Contributor

@jboix jboix commented Mar 19, 2024

Description

Updates pillarbox version for the demo and all samples.

## Changes made

  • Remove fill option from player initialisation.

@jboix jboix requested a review from amtins March 19, 2024 10:20
Copy link

github-actions bot commented Mar 19, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://SRGSSR.github.io/pillarbox-web-demo/pr-preview/pr-25/
on branch gh-pages at 2024-03-20 09:35 UTC

@jboix jboix self-assigned this Mar 19, 2024
Since version 1.3.0 of pillarbox the `fill` option is `true` by default.
Copy link
Member

@amtins amtins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jboix jboix added this pull request to the merge queue Mar 21, 2024
Merged via the queue into main with commit f5e2116 Mar 21, 2024
2 checks passed
@jboix jboix deleted the chore/update-pillarbox-version branch March 21, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants