Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report AirPlay media selection issues to Apple #511

Open
6 tasks
defagos opened this issue Aug 9, 2023 · 1 comment
Open
6 tasks

Report AirPlay media selection issues to Apple #511

defagos opened this issue Aug 9, 2023 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed
Milestone

Comments

@defagos
Copy link
Member

defagos commented Aug 9, 2023

As a Pillarbox developer I want to avoid introducing nasty workarounds for corner cases. Player item currentMediaSelection is currently broken over AirPlay resulting in minor bugs. This issue should be reported to Apple.

Acceptance criteria

  • currentMediaSelection issues have been reported to Apple.

Hints

  • currentMediaSelection reports updates during playback but does not deliver the initial value. Current workaround is to wait until the player is ready to play, at which point reading the property delivers the current value. A publisher can then be used to get further updates resulting from media selection updates triggered by the user.
  • currentMediaSelection is incorrect over AirPlay, which can simply be observed by periodically logging the value for the current item (using a KVO-publisher should be avoided for the bug report because of the issue described above). As a result the following fails with Pillarbox as well as the vanilla player and player UI:
    • Open Apple 16:9 basic example.
    • Pick Japanese SDH subtitles so that the selection is saved with MediaAccessibility.
    • Close the player.
    • Open the player. Subtitles are correctly set in Japanese and marked as such in the selection menu.
    • Enable AirPlay from the Control Center.
    • Open the player. Subtitles are not incorrectly reported as English SDH.

Tasks

  • Check behavior with various iOS / tvOS version and system language / SDH / AD combinations in the following scenarios (report what language is returned by currentMediaSelection and which subtitles, if any, are visible on screen):
    • Pillarbox player, custom UI.
    • Pillarbox player, system UI.
    • Vanilla player and UI.
  • Write bug report.
  • Document as known issue in Pillarbox documentation.
@defagos defagos added this to Pillarbox Aug 9, 2023
@defagos defagos converted this from a draft issue Aug 9, 2023
@defagos defagos added bug Something isn't working help wanted Extra attention is needed labels Aug 9, 2023
@defagos defagos added this to the Tracks milestone Aug 9, 2023
@defagos defagos mentioned this issue Aug 18, 2023
8 tasks
@defagos
Copy link
Member Author

defagos commented Oct 14, 2024

This is a tvOS bug since the behavior does not depend on the casting device iOS version, rather on the receiver tvOS version. This issue was partially fixed in tvOS 18 (tested with tvOS 18 beta):

  • The reported subtitle selection is now correct on the casting device...
  • ... but the subtitles are not displayed on the receiver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant