-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic support for subtitles and audio tracks #501
Comments
I introduced a
Currently
|
Interesting use case to write as a unit test:
Interesting use cases also include:
|
The current implementation based on |
The current media selection is incorrectly reported over AirPlay, see #511. |
Wrong. This works but only for subtitles marked with |
I implemented behavior similar to
As said above we could allow custom |
As a user I want to be able to see subtitles and audio tracks available for some content, as well as to select / deselect a track.
Acceptance criteria
Hints
If this makes sense track management can be moved to a tracker management state object, which can be bound to a player like progress tracker or visibility tracker can. However this might not be justified here:
Documentation
See official documentation.
Tasks
Attempt to build a test stream withShaka Packager manages this flag internally.AUTOSELECT
set toYES
for only some subtitles, if possible. Write a dedicated unit test that verifies we are not only relying on MediaAccessibility.The text was updated successfully, but these errors were encountered: