feat: add registration attributes and guards #171

sharmaigne · 2024-02-11T17:07:33Z

No description provided.

…rds for registrationType

vercel · 2024-02-11T17:07:39Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
sparcs-event-platform	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 13, 2024 2:42pm

ArJSarmiento

Just a bit more changes @sharmaigne . Thanks!

ArJSarmiento · 2024-02-29T00:42:36Z

backend/usecase/discount_usecase.py

+        event = EventUsecase.get_event(event_id)
+        if event.registrationType == RegistrationType.REDIRECT:
+            message = 'Error: No discounts for REDIRECT registrationType'
+            return JSONResponse(status_code=HTTPStatus.BAD_REQUEST, content={'message': message})


Should be error NOT_FOUND

ArJSarmiento · 2024-02-29T00:42:41Z

backend/usecase/discount_usecase.py

+        event = EventUsecase.get_event(event_id)
+        if event.registrationType == RegistrationType.REDIRECT:
+            message = 'Error: No discounts for REDIRECT registrationType'
+            return JSONResponse(status_code=HTTPStatus.BAD_REQUEST, content={'message': message})


Should be error NOT_FOUND

ArJSarmiento · 2024-02-29T00:42:45Z

backend/usecase/discount_usecase.py

+        event = EventUsecase.get_event(event_id)
+        if event.registrationType == RegistrationType.REDIRECT:
+            message = 'Error: No discounts for REDIRECT registrationType'
+            return JSONResponse(status_code=HTTPStatus.BAD_REQUEST, content={'message': message})


Should be error NOT_FOUND

ArJSarmiento · 2024-02-29T00:44:51Z

backend/usecase/evaluation_usecase.py

+        event = EventUsecase.get_event(
+            event_id
+        )  # NOTE: am i doing this right, i don't wanna add another param but di pud ko sure if fetching the whole thing is the best move?


Use the EventRepository for this.

ArJSarmiento · 2024-02-29T00:45:59Z

backend/usecase/evaluation_usecase.py

+        event = EventUsecase.get_event(event_id)
+        if event.registrationType == RegistrationType.REDIRECT:
+            message = 'Error: No evaluations for REDIRECT registrationType'
+            return JSONResponse(status_code=HTTPStatus.BAD_REQUEST, content={'message': message})


Should be NOT_FOUND

backend/usecase/evaluation_usecase.py

ArJSarmiento · 2024-02-29T00:46:31Z

backend/usecase/registration_usecase.py

@@ -45,6 +46,12 @@ def create_registration(self, registration_in: RegistrationIn) -> Union[JSONResp
            Union[JSONResponse, RegistrationOut]: If successful, returns the created registration entry.
                If unsuccessful, returns a JSONResponse with an error message.
        """
+
+        event = EventUsecase.get_event(registration_in.eventId)


Use EventRepository for this. Apply for all instances. Use cases should call repositories for data fetching.

ArJSarmiento · 2024-03-27T11:26:13Z

Can you please resolve merge conflicts @sharmaigne ?

…into 158-be-add-redirect-register-option

ArJSarmiento

More changes needed @ASPactores

Also lease add guards for the following:

certificate usecase
preregistration_usecase

Thanks!

ArJSarmiento · 2024-04-14T07:52:58Z

backend/usecase/discount_usecase.py

+        event = EventUsecase.get_event(DiscountIn.eventId)
+        if event.registrationType == RegistrationType.REDIRECT:
+            message = 'Error: Discounts should not be created for REDIRECT registrationType'
+            return JSONResponse(status_code=HTTPStatus.NOT_FOUND, content={'message': message})


This should BAD_REQUEST.

Should be BAD_REQUEST for CUD operations and NOT_FOUND for READ operations

ArJSarmiento · 2024-04-14T07:54:19Z

backend/usecase/evaluation_usecase.py

@@ -33,6 +35,13 @@ def create_evaluation(self, evaluation_list_in: EvaluationListIn) -> Union[JSONR
        """
        event_id = evaluation_list_in.eventId
        registration_id = evaluation_list_in.registrationId
+
+        # NOTE: next three lines copy pasted a lot, should this be a helper or nah kay mubo ra


Remove comment

ArJSarmiento · 2024-04-14T07:54:48Z

backend/usecase/evaluation_usecase.py

+        event = EventUsecase.get_event(event_id)
+        if event.registrationType == RegistrationType.REDIRECT:
+            message = 'Error: No evaluation to update for REDIRECT registrationType'
+            return JSONResponse(status_code=HTTPStatus.NOT_FOUND, content={'message': message})


This should BAD_REQUEST.

Should be BAD_REQUEST for CUD operations and NOT_FOUND for READ operations

ArJSarmiento · 2024-04-14T07:55:33Z

backend/usecase/discount_usecase.py

+        event = EventUsecase.get_event(event_id)
+        if event.registrationType == RegistrationType.REDIRECT:
+            message = 'Error: No discounts for REDIRECT registrationType'
+            return JSONResponse(status_code=HTTPStatus.NOT_FOUND, content={'message': message})


This should BAD_REQUEST.

Should be BAD_REQUEST for CUD operations and NOT_FOUND for READ operations

ArJSarmiento · 2024-04-14T08:00:44Z

backend/usecase/registration_usecase.py

@@ -228,6 +240,11 @@ def get_registration(self, event_id: str, registration_id: str) -> Union[JSONRes

        """

+        event = EventUsecase.get_event(event_id)
+        if event.registrationType == RegistrationType.REDIRECT:


This should NOT_FOUND.

Should be BAD_REQUEST for CUD operations and NOT_FOUND for READ operations

ArJSarmiento · 2024-04-14T08:11:32Z

backend/usecase/evaluation_usecase.py

+        event = EventsRepository.query_events(event_id)
+        if event.registrationType == RegistrationType.REDIRECT:
+            message = 'Error: Evaluation should not be created for REDIRECT registrationType'
+            return JSONResponse(status_code=HTTPStatus.BAD_REQUEST, content={'message': message})


This returns an error since EventsRepository.query_events returns a tuple and not the event entry

Use self.__events_repository for accessing the entry not the usecase

check if event exists first before accessing the registrationType attribute so do if event and event.registrationType

APPLY FOR ALL INSTANCES

ArJSarmiento · 2024-04-14T08:14:27Z

backend/usecase/registration_usecase.py

+        event = EventsRepository.query_events(registration_in.eventId)
+        if event.registrationType == RegistrationType.REDIRECT:
+            message = 'Registrations should not be created for REDIRECT registration type'
+            return JSONResponse(status_code=HTTPStatus.BAD_REQUEST, content={'message': message})


Use self.__events_repository for accessing the entry not the usecase

Check if event exists first before accessing the registrationType attribute so do if event and event.registrationType

APPLY FOR ALL INSTANCES

ArJSarmiento · 2024-04-14T08:15:35Z

backend/usecase/registration_usecase.py

Please add guards to create_registration_approval_flow also

ArJSarmiento · 2024-04-14T08:21:22Z

backend/usecase/registration_usecase.py

@@ -264,6 +281,11 @@ def get_registration_by_email(self, event_id: str, email: str) -> RegistrationOu
            registrations,
            message,
        ) = self.__registrations_repository.query_registrations_with_email(event_id=event_id, email=email)
+        event = EventUsecase.get_event(event_id)
+        if event.registrationType == RegistrationType.REDIRECT:


This should NOT_FOUND.

Should be BAD_REQUEST for CUD operations and NOT_FOUND for READ operations

ArJSarmiento · 2024-04-14T08:21:38Z

backend/usecase/registration_usecase.py

+        event = EventUsecase.get_event(event_id)
+        if event.registrationType == RegistrationType.REDIRECT:
+            message = 'No registrations for REDIRECT registration type'
+            return JSONResponse(status_code=HTTPStatus.BAD_REQUEST, content={'message': message})


This should NOT_FOUND.

Should be BAD_REQUEST for CUD operations and NOT_FOUND for READ operations

feat: add registrationType and redirectRegisterUrl to Events, add gua…

6ba24eb

…rds for registrationType

style: fix line length and trailing whitespace

682e587

vercel bot deployed to Preview February 11, 2024 17:27 View deployment

fix: formatting

4ea512c

vercel bot deployed to Preview February 29, 2024 00:41 View deployment

ArJSarmiento requested changes Feb 29, 2024

View reviewed changes

ArJSarmiento mentioned this pull request Apr 12, 2024

BE - Add Redirect Register Option #158

Open

ASPactores added 3 commits April 13, 2024 21:34

Merge branch 'stage' of https://github.com/SPARCS-UP-Mindanao/TechTix …

c56174f

…into 158-be-add-redirect-register-option

fix: fixed pydantic.attribute error

dbf036e

feat: implemented coments

ca6dcce

vercel bot deployed to Preview April 13, 2024 14:40 View deployment

fix: formatting fix

06095a1

vercel bot deployed to Preview April 13, 2024 14:42 View deployment

ArJSarmiento requested changes Apr 14, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add registration attributes and guards #171

feat: add registration attributes and guards #171

sharmaigne commented Feb 11, 2024

vercel bot commented Feb 11, 2024 •

edited

Loading

ArJSarmiento left a comment

ArJSarmiento Feb 29, 2024

ArJSarmiento Feb 29, 2024

ArJSarmiento Feb 29, 2024

ArJSarmiento Feb 29, 2024

ArJSarmiento Feb 29, 2024

ArJSarmiento Feb 29, 2024

ArJSarmiento commented Mar 27, 2024

ArJSarmiento left a comment

ArJSarmiento Apr 14, 2024

ArJSarmiento Apr 14, 2024

ArJSarmiento Apr 14, 2024

ArJSarmiento Apr 14, 2024

ArJSarmiento Apr 14, 2024

ArJSarmiento Apr 14, 2024

ArJSarmiento Apr 14, 2024

ArJSarmiento Apr 14, 2024

ArJSarmiento Apr 14, 2024

ArJSarmiento Apr 14, 2024

feat: add registration attributes and guards #171

Are you sure you want to change the base?

feat: add registration attributes and guards #171

Conversation

sharmaigne commented Feb 11, 2024

vercel bot commented Feb 11, 2024 • edited Loading

ArJSarmiento left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ArJSarmiento commented Mar 27, 2024

ArJSarmiento left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vercel bot commented Feb 11, 2024 •

edited

Loading