Fix release workflows to disconnect from pypi #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update strategies * fix pre-commit * create json parse strategy * update parse strategies * Updated dlite storage path * Fixed duplication of data model names. Improved readability of the code * Instanciate the Pydantic datamodel from a dict * Added error handling# * Set collection_id. Updated datamodel * Updated parse strategy * Update json strategy config * Update json strategy config * Added entity to config * camel case storagePath * rename storage path * Refactor initialize method * add quantity to generate * Revert "add quantity to generate" This reverts commit e000232. * remove unused session parameter * update otelib version * update requirements.txt * update oteapi-core * fix pylint errors * remove unnecessary session parameter * fix otelib version * fix tests * fix test_generate * fix syntax * fix test_generate collection * fix test_filter * fix test_generate_collection * update dataresource in test_convert * fix test_convert, and pylint * fix tests * test_parse_json * test_parse_json * fix test_parse * fix test_convert * fix pylint errors * replace resourceconfig with Parserconfig in parse strategies * fix parse strategy * - * revert * Allow for defining triplestore backend in the mapping strategy (EMMC-ASBL#225) * Allow for defining triplestore backend in the mapping strategy Co-authored-by: Thomas F. Hagelien <[email protected]> * - * remove unnecessary files * fix test_parse_json * - * fix import error * fix path issue * fix test_mapping * - * fix collection * update config in test_config * fix test_parse_excel * fix test_parse_excel * - * fix excel parser * - * fix test_image_config * remove unnecessary startegies * run pre-commit * fix pylint issues * fix pylint and docs * remove unused strategies and add doc strings * remove unused test entities and files * - * - * - * fix warning * Revert "Remove session" --------- Co-authored-by: Thomas F. Hagelien <[email protected]> Co-authored-by: Thomas Hagelien <[email protected]>
* Bump pypa/gh-action-pypi-publish from 1.8.12 to 1.8.14 (EMMC-ASBL#224) Bumps [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish) from 1.8.12 to 1.8.14. - [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases) - [Commits](pypa/gh-action-pypi-publish@v1.8.12...v1.8.14) --- updated-dependencies: - dependency-name: pypa/gh-action-pypi-publish dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update pytest requirement from ~=8.0 to ~=8.1 (EMMC-ASBL#227) Updates the requirements on [pytest](https://github.com/pytest-dev/pytest) to permit the latest version. - [Release notes](https://github.com/pytest-dev/pytest/releases) - [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst) - [Commits](pytest-dev/pytest@8.0.0...8.1.1) --- updated-dependencies: - dependency-name: pytest dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update mkdocstrings[python] requirement from ~=0.24.0 to ~=0.24.1 (EMMC-ASBL#226) Updates the requirements on [mkdocstrings[python]](https://github.com/mkdocstrings/mkdocstrings) to permit the latest version. - [Release notes](https://github.com/mkdocstrings/mkdocstrings/releases) - [Changelog](https://github.com/mkdocstrings/mkdocstrings/blob/main/CHANGELOG.md) - [Commits](mkdocstrings/mkdocstrings@0.24.0...0.24.1) --- updated-dependencies: - dependency-name: mkdocstrings[python] dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update `pre-commit` hooks --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Treesa Joseph <[email protected]>
This reverts commit 620d37b.
This reverts commit 620d37b.
* update strategies * fix pre-commit * create json parse strategy * update parse strategies * Updated dlite storage path * Fixed duplication of data model names. Improved readability of the code * Instanciate the Pydantic datamodel from a dict * Added error handling# * Set collection_id. Updated datamodel * Updated parse strategy * Update json strategy config * Update json strategy config * Added entity to config * camel case storagePath * rename storage path * Refactor initialize method * add quantity to generate * Revert "add quantity to generate" This reverts commit e000232. * remove unused session parameter * update otelib version * update requirements.txt * update oteapi-core * fix pylint errors * remove unnecessary session parameter * fix otelib version * fix tests * fix test_generate * fix syntax * fix test_generate collection * fix test_filter * fix test_generate_collection * update dataresource in test_convert * fix test_convert, and pylint * fix tests * test_parse_json * test_parse_json * fix test_parse * fix test_convert * fix pylint errors * replace resourceconfig with Parserconfig in parse strategies * fix parse strategy * - * revert * Allow for defining triplestore backend in the mapping strategy (EMMC-ASBL#225) * Allow for defining triplestore backend in the mapping strategy Co-authored-by: Thomas F. Hagelien <[email protected]> * - * remove unnecessary files * fix test_parse_json * - * fix import error * fix path issue * fix test_mapping * - * fix collection * update config in test_config * fix test_parse_excel * fix test_parse_excel * - * fix excel parser * - * fix test_image_config * remove unnecessary startegies * run pre-commit * fix pylint issues * fix pylint and docs * remove unused strategies and add doc strings * remove unused test entities and files * - * - * - * fix warning * Revert "Remove session" --------- Co-authored-by: Thomas F. Hagelien <[email protected]> Co-authored-by: Thomas Hagelien <[email protected]>
|
Maybe we can remove certain steps in the CD_release.yml as it doesn't have access to certain env variables /secrets? |
CasperWA
requested changes
Mar 18, 2024
There was a problem hiding this comment.
I thought we were using SINTEF/ci-cd here. That workflow has an option to not publish on PyPI using the publish_on_pypi input parameter. This one does not.
But here it is as easy as removing that step in the workflow.
Indeed, for this to work in a more optimized way, SINTEF/ci-cd callable workflows should be used. In any case - this is fine, as long as the publish to pypi step is removed :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Type of change:
Checklist for the reviewer:
This checklist should be used as a help for the reviewer.