Serialize just once random_referenced objects #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jofsky
previously approved these changes
Jul 11, 2022
| @@ -130,6 +130,7 @@ def __init__( | |||
| # They survive iterations and continuations. | |||
| self.persistent_nicknames = {} | |||
| self.persistent_objects_by_table = {} | |||
| self.persistent_random_referenceable_objects = [] | |||
There was a problem hiding this comment.
Is there a reason this isn't a dict?
auto-merge was automatically disabled
February 8, 2023 20:32
Merge queue setting changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a just_once template created multiple objects, and was randomly referenced,
only the most recently created object was saved across continuations. Now they
are all saved.
Also added code to de-serialize LazyLoadedObjectRecords from the SQL DB so they
can be serialized as YAML for continuation.