Group logic #72
Merged
Group logic #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francisvaut
previously requested changes
Mar 9, 2024
There was a problem hiding this comment.
Looks good, also complete and comprehensive tests.
Only (minor) problem I see is that it is currently possible for a teacher to assign a score to a group greater than the max score of the corresponding project. It might be more preferable to implement this in our backend without relying solely on a max score limit in our frontend
EwoutV
requested changes
Mar 9, 2024
Good point, should be added now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #64
closes #65 => see #71 for further features
closes #66