chore: no extra checks fix #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Topvennie
requested changes
May 20, 2024
Topvennie
approved these changes
May 21, 2024
Comment on lines
+39
to
+51
| if extra_checks_count: | ||
| passed_extra_checks_submission_ids = ExtraCheckResult.objects.filter( | ||
| submission__group__project=instance, | ||
| submission__is_valid=True, | ||
| result=StateEnum.SUCCESS | ||
| ).values_list('submission__id', flat=True) | ||
|
|
||
| passed_extra_checks_group_ids = Submission.objects.filter( | ||
| id__in=passed_extra_checks_submission_ids | ||
| ).values_list('group_id', flat=True) | ||
|
|
||
| unique_groups = set(passed_extra_checks_group_ids) | ||
| extra_checks_passed = len(unique_groups) |
There was a problem hiding this comment.
If you're bored, I'm fairly certain this can be optimized as in terms of the amount of db calls.
However I'm good to leave it like that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #438
Perhaps if I have enough time left I will also make the ProjectMeter only show the checks which are actually relevant for the corresponding project.