Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment #273

Merged
merged 209 commits into from
Apr 9, 2024
Merged

Deployment #273

merged 209 commits into from
Apr 9, 2024

Conversation

EwoutV
Copy link
Contributor

@EwoutV EwoutV commented Apr 9, 2024

No description provided.

Topvennie and others added 19 commits April 8, 2024 23:06
* docker_view

* chore: Added check views

* chore: dynamic file paths

* chore: type hints

* chore: views

* chore: file_path uuid

* chore: run checks when checks changes

* chore: remove prints

* chore: do todo's

* chore: fix tests by commenting them out

* chore: move signal

* chore: moved everything to signals

* chore: merge

* fix: fixture

---------

Co-authored-by: EwoutV <[email protected]>
* chore: add make teacher script

* fix: added psychology faculty icon

---------

Co-authored-by: tyboro2002 <[email protected]>
* chore: add make teacher script

* fix: makeTeacher command

* chore: add bulk adding to the types

* speed up seeders

---------

Co-authored-by: Bram Meir <[email protected]>
* chore: add make teacher script

* fix: added psychology faculty icon

* fix: faculty image filter

* chore: linting

* feat: role user mixin

* Calendar view improvements (#257)

* chore: add make teacher script

* fix: added psychology faculty icon

---------

Co-authored-by: tyboro2002 <[email protected]>

* chore: user permissions account for is_active

* chore: added role management tests, extracted common logic in helpers

* fix: student service parameter

* chore: linting

* chore: removed comment in seeder

---------

Co-authored-by: tyboro2002 <[email protected]>
* chore: project creation faculty

* fix: faculty added when course created

* chore: start docker upload project creation

* chore: init upload zip structure

* chore: still issues with file-upload

* chore: fix uploaded zip file parsing

* fix: cleanup

* fix: linting

* fix: tests

* fix: hopefully last fix
* chore: start update course view + based on roles

* feat: more placeholder images

* chore: layout improvements, past deadline project filter

* chore: linting

---------

Co-authored-by: Bram Meir <[email protected]>
Copy link
Contributor

@Topvennie Topvennie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't read any of the 18k lines but yes very good

@EwoutV
Copy link
Contributor Author

EwoutV commented Apr 9, 2024

Didn't read any of the 18k lines but yes very good

Tamzak in team 🙄

Copy link
Contributor

@tyboro2002 tyboro2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when a user logs in it isnt asigned to its role (student, teacher, assistant)

reproduce:

  • rm db
  • development -fbc
  • log in
  • see that you dont have any role

@EwoutV EwoutV requested a review from tyboro2002 April 9, 2024 19:01
Copy link
Contributor

@tyboro2002 tyboro2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@EwoutV EwoutV merged commit 31d69f5 into main Apr 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants