Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run submission checks #268

Merged
merged 6 commits into from
Apr 11, 2024
Merged

Run submission checks #268

merged 6 commits into from
Apr 11, 2024

Conversation

Topvennie
Copy link
Contributor

@Topvennie Topvennie commented Apr 9, 2024 •
edited
Loading

Breaking change for the frontend (see refactor change)

  • Use a persistent backend for Celery
  • Auto discover tasks defined in a tasks module
  • Added PATCH support for projects (Backend: Cleanup #225)
  • Refactor checks & submissions
    • Make use of polymorphic library to abstract structure checks and extra checks
    • Both checks can be rerun, have a state and more
    • Get submission returns a field results which contains a list of dicts Screenshot from 2024-04-11 16-40-56
    • It's up to the client to filter out the type of result
  • Added support for models being passed to celery tasks
  • Added -k flag to the test.sh script which doesn't remove the images. Avoids rebuilding the image everytime and drastically speeds up the testing process.
  • Commented out tests (will be readded at a later stage) @DeLany123
  • Added some TODO's and test file that will be removed in a later stage. The purpose of this pr is to allow the frontend to start adapting to the new models.

Closes #206

@Topvennie Topvennie added this to the Final milestone milestone Apr 9, 2024
@Topvennie Topvennie self-assigned this Apr 9, 2024
EwoutV
EwoutV approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@EwoutV EwoutV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😏 👌

@Topvennie Topvennie marked this pull request as ready for review April 11, 2024 16:01
@Topvennie Topvennie requested review from EwoutV and DeLany123 April 11, 2024 16:02
EwoutV
EwoutV approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@EwoutV EwoutV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@EwoutV EwoutV merged commit fc2ac86 into development Apr 11, 2024
3 checks passed
@EwoutV EwoutV deleted the run_extra_checks branch April 11, 2024 20:29
@Topvennie Topvennie restored the run_extra_checks branch April 11, 2024 20:35
francisvaut pushed a commit that referenced this pull request Apr 12, 2024
@Topvennie @francisvaut
Run submission checks (#268)
4021f7f 
* chore: celery #206

* chore: Support partial update for project

* chore: support patch for project 2

* refactor!: rework checks and submissions

* chore: allow models passed to tasks

* feat: added -k to test.sh
EwoutV added a commit that referenced this pull request Apr 12, 2024
@francisvaut @EwoutV
@Topvennie @BramMeir
Services fix, tests (#297)
415911d 
* test: create course

* fix: send id to backend when creating faculty

* test: create faculty

* test: create group

* test: cleanup create tests

* test: assistant type

* test: services and types folder

* test: start with create project

* test: cleanup setup file

* test: cleanup request handlers

* test: reset services + fix mistakes in teacher/assistant service

* chore: fix linting

* test: create project

* chore: linting autofix

* chore: bring back multipart/from-data

* Better academic year selector, filtering and sorting (#292)

* feat: academic year selector, better pagination and filtering composables

* chore: added course pagination

* Run submission checks (#268)

* chore: celery #206

* chore: Support partial update for project

* chore: support patch for project 2

* refactor!: rework checks and submissions

* chore: allow models passed to tasks

* feat: added -k to test.sh

* fix: re-add translations

* chore: display faculty in course edit

* fix: courses to create projects filtered on selected calendar date

* fix: make teacher command

* fix: linting

* test: admin delete

* test: fix service mistake, assistant delete

---------

Co-authored-by: Ewout Verlinde <[email protected]>
Co-authored-by: Vincent Vallaeys <[email protected]>
Co-authored-by: Bram Meir <[email protected]>
DeLany123 pushed a commit that referenced this pull request Apr 15, 2024
@Topvennie @DeLany123
Run submission checks (#268)
bb4096c 
* chore: celery #206

* chore: Support partial update for project

* chore: support patch for project 2

* refactor!: rework checks and submissions

* chore: allow models passed to tasks

* feat: added -k to test.sh
DeLany123 pushed a commit that referenced this pull request Apr 15, 2024
@francisvaut @EwoutV
@Topvennie @BramMeir @DeLany123
Services fix, tests (#297)
ab63516 
* test: create course

* fix: send id to backend when creating faculty

* test: create faculty

* test: create group

* test: cleanup create tests

* test: assistant type

* test: services and types folder

* test: start with create project

* test: cleanup setup file

* test: cleanup request handlers

* test: reset services + fix mistakes in teacher/assistant service

* chore: fix linting

* test: create project

* chore: linting autofix

* chore: bring back multipart/from-data

* Better academic year selector, filtering and sorting (#292)

* feat: academic year selector, better pagination and filtering composables

* chore: added course pagination

* Run submission checks (#268)

* chore: celery #206

* chore: Support partial update for project

* chore: support patch for project 2

* refactor!: rework checks and submissions

* chore: allow models passed to tasks

* feat: added -k to test.sh

* fix: re-add translations

* chore: display faculty in course edit

* fix: courses to create projects filtered on selected calendar date

* fix: make teacher command

* fix: linting

* test: admin delete

* test: fix service mistake, assistant delete

---------

Co-authored-by: Ewout Verlinde <[email protected]>
Co-authored-by: Vincent Vallaeys <[email protected]>
Co-authored-by: Bram Meir <[email protected]>
DeLany123 pushed a commit that referenced this pull request Apr 15, 2024
@Topvennie @DeLany123
Run submission checks (#268)
25bf382 
* chore: celery #206

* chore: Support partial update for project

* chore: support patch for project 2

* refactor!: rework checks and submissions

* chore: allow models passed to tasks

* feat: added -k to test.sh
DeLany123 pushed a commit that referenced this pull request Apr 15, 2024
@Topvennie @DeLany123
Run submission checks (#268)
635f2d2 
* chore: celery #206

* chore: Support partial update for project

* chore: support patch for project 2

* refactor!: rework checks and submissions

* chore: allow models passed to tasks

* feat: added -k to test.sh
DeLany123 pushed a commit that referenced this pull request Apr 15, 2024
@Topvennie @DeLany123
Run submission checks (#268)
66fdc00 
* chore: celery #206

* chore: Support partial update for project

* chore: support patch for project 2

* refactor!: rework checks and submissions

* chore: allow models passed to tasks

* feat: added -k to test.sh
DeLany123 pushed a commit that referenced this pull request Apr 17, 2024
@Topvennie @DeLany123
Run submission checks (#268)
ad51fda 
* chore: celery #206

* chore: Support partial update for project

* chore: support patch for project 2

* refactor!: rework checks and submissions

* chore: allow models passed to tasks

* feat: added -k to test.sh
DeLany123 pushed a commit that referenced this pull request Apr 17, 2024
@Topvennie @DeLany123
Run submission checks (#268)
919f298 
* chore: celery #206

* chore: Support partial update for project

* chore: support patch for project 2

* refactor!: rework checks and submissions

* chore: allow models passed to tasks

* feat: added -k to test.sh
DeLany123 pushed a commit that referenced this pull request Apr 17, 2024
@Topvennie @DeLany123
Run submission checks (#268)
9de7d43 
* chore: celery #206

* chore: Support partial update for project

* chore: support patch for project 2

* refactor!: rework checks and submissions

* chore: allow models passed to tasks

* feat: added -k to test.sh
DeLany123 pushed a commit that referenced this pull request Apr 17, 2024
@Topvennie @DeLany123
Run submission checks (#268)
28f878e 
* chore: celery #206

* chore: Support partial update for project

* chore: support patch for project 2

* refactor!: rework checks and submissions

* chore: allow models passed to tasks

* feat: added -k to test.sh
DeLany123 pushed a commit that referenced this pull request Apr 17, 2024
@Topvennie @DeLany123
Run submission checks (#268)
d20fd89 
* chore: celery #206

* chore: Support partial update for project

* chore: support patch for project 2

* refactor!: rework checks and submissions

* chore: allow models passed to tasks

* feat: added -k to test.sh
EwoutV added a commit that referenced this pull request Apr 18, 2024
@DeLany123 @EwoutV @Topvennie
Submission view (#333)
56c21f7 
* feat: allsubmissions view

* Better academic year selector, filtering and sorting (#292)

* feat: academic year selector, better pagination and filtering composables

* chore: added course pagination

* Run submission checks (#268)

* chore: celery #206

* chore: Support partial update for project

* chore: support patch for project 2

* refactor!: rework checks and submissions

* chore: allow models passed to tasks

* feat: added -k to test.sh

* chore: improved layout

* feat: allsubmissions view 2

* Run submission checks (#268)

* chore: celery #206

* chore: Support partial update for project

* chore: support patch for project 2

* refactor!: rework checks and submissions

* chore: allow models passed to tasks

* feat: added -k to test.sh

* chore: improved layout

* Frontend rebased submission view

* chore: commit before merge

* chore: commit before rebasing

* fix: Frontend works on new submissions

* Better academic year selector, filtering and sorting (#292)

* feat: academic year selector, better pagination and filtering composables

* chore: added course pagination

* Run submission checks (#268)

* chore: celery #206

* chore: Support partial update for project

* chore: support patch for project 2

* refactor!: rework checks and submissions

* chore: allow models passed to tasks

* feat: added -k to test.sh

* chore: improved layout

* Frontend rebased submission view

* chore: commit before merge

* chore: finish logic submissionView.vue

* chore: bugfixes and layout

* chore: Finished submissionView

* chore: lint fixes for #333

* chore: Removed useless checks #333

* chore: impossible to fail now #333

* chore: impossible to fail now v2 #333

* chore: changes to make Ewout happy

---------

Co-authored-by: Ewout Verlinde <[email protected]>
Co-authored-by: Vincent Vallaeys <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EwoutV EwoutV EwoutV approved these changes

@DeLany123 DeLany123 Awaiting requested review from DeLany123

Assignees

@Topvennie Topvennie

Labels
None yet
Projects
None yet
Milestone
Final milestone
Development

Successfully merging this pull request may close these issues.

Deployment: Celery persistent backend
2 participants
@Topvennie @EwoutV