chore: actually remove try catch block, because it's not necessary #407

SELab-2 · May 21, 2024 · cf4efa9 · cf4efa9
1 parent 54305f3
commit cf4efa9
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 37 deletions.
diff --git a/frontend/src/composables/services/course.service.ts b/frontend/src/composables/services/course.service.ts
@@ -66,28 +66,24 @@ export function useCourses(): CoursesState {
         const { addSuccessMessage } = useMessagesStore();
 
         const endpoint = endpoints.courses.index;
-        try {
-            await create<Course>(
-                endpoint,
-                {
-                    id: courseData.id,
-                    name: courseData.name,
-                    description: courseData.description,
-                    excerpt: courseData.excerpt,
-                    academic_startyear: courseData.academic_startyear,
-                    private_course: courseData.private_course,
-                    faculty: courseData.faculty?.id,
-                },
-                course,
-                Course.fromJSON,
-            );
-            addSuccessMessage(
-                t('toasts.messages.success'),
-                t('toasts.messages.courses.create.success', [course.value?.name]),
-            );
-        } catch (e) {
-            console.log(e);
-        }
+        await create<Course>(
+            endpoint,
+            {
+                id: courseData.id,
+                name: courseData.name,
+                description: courseData.description,
+                excerpt: courseData.excerpt,
+                academic_startyear: courseData.academic_startyear,
+                private_course: courseData.private_course,
+                faculty: courseData.faculty?.id,
+            },
+            course,
+            Course.fromJSON,
+        );
+        addSuccessMessage(
+            t('toasts.messages.success'),
+            t('toasts.messages.courses.create.success', [course.value?.name]),
+        );
     }
 
     async function updateCourse(courseData: Course): Promise<void> {

diff --git a/frontend/src/composables/services/project.service.ts b/frontend/src/composables/services/project.service.ts
@@ -101,15 +101,11 @@ export function useProject(): ProjectState {
             requestData.number_groups = numberOfGroups;
         }
 
-        try {
-            await create<Project>(endpoint, requestData, project, Project.fromJSON, 'multipart/form-data');
-            addSuccessMessage(
-                t('toasts.messages.success'),
-                t('toasts.messages.projects.create.success', [project.value?.name]),
-            );
-        } catch (e) {
-            console.log(e);
-        }
+        await create<Project>(endpoint, requestData, project, Project.fromJSON, 'multipart/form-data');
+        addSuccessMessage(
+            t('toasts.messages.success'),
+            t('toasts.messages.projects.create.success', [project.value?.name]),
+        );
     }
 
     async function updateProject(projectData: Project): Promise<void> {

diff --git a/frontend/src/composables/services/submission.service.ts b/frontend/src/composables/services/submission.service.ts
@@ -44,12 +44,9 @@ export function useSubmission(): SubmissionState {
         uploadedFiles.forEach((file: File) => {
             formData.append('files', file); // Gebruik 'files' in plaats van 'files[]'
         });
-        try {
-            await create(endpoint, formData, submission, Submission.fromJSONCreate, 'multipart/form-data');
-            addSuccessMessage(t('toasts.messages.success'), t('toasts.messages.submissions.create.success'));
-        } catch (e) {
-            console.log(e);
-        }
+
+        await create(endpoint, formData, submission, Submission.fromJSONCreate, 'multipart/form-data');
+        addSuccessMessage(t('toasts.messages.success'), t('toasts.messages.submissions.create.success'));
     }
 
     async function deleteSubmission(id: string): Promise<void> {