Maak projecten automatisch zichtbaar op een bepaald tijdstip #269
+596
−326
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,59 +1,93 @@ | ||
| import { DatePicker, Form, FormInstance, Input, Switch, Typography } from "antd" | ||
| import { useTranslation } from "react-i18next" | ||
| import { FC, useEffect, useState } from "react" | ||
| import MarkdownEditor from "../../input/MarkdownEditor" | ||
|
|
||
| const GeneralFormTab: FC<{ form: FormInstance }> = ({ form }) => { | ||
| const { t } = useTranslation() | ||
| const description = Form.useWatch("description", form) | ||
| const visible = Form.useWatch("visible", form) | ||
| const [isVisible, setIsVisible] = useState(visible) | ||
| const [savedVisibleAfter, setSavedVisibleAfter] = useState<string | null>(null) | ||
|
|
||
| useEffect(() => { | ||
| setIsVisible(visible) | ||
| if (visible && savedVisibleAfter) { | ||
| form.setFieldsValue({ visibleAfter: null }) | ||
| } | ||
| }, [visible]) | ||
|
|
||
| const handleVisibleChange = (checked: boolean) => { | ||
| setIsVisible(checked) | ||
| if (checked) { | ||
| setSavedVisibleAfter(form.getFieldValue("visibleAfter")) | ||
| form.setFieldsValue({ visibleAfter: null }) | ||
| } else { | ||
| form.setFieldsValue({ visibleAfter: savedVisibleAfter }) | ||
| } | ||
| } | ||
|
|
||
| return ( | ||
| <> | ||
| <Form.Item | ||
| label={t("project.change.name")} | ||
| name="name" | ||
| rules={[{ required: true, message: t("project.change.nameMessage") }]} | ||
| > | ||
| <Input /> | ||
| </Form.Item> | ||
|
|
||
| <Typography.Text> | ||
| {t("project.change.description")} | ||
| </Typography.Text> | ||
| <MarkdownEditor value={description} maxLength={5000} /> | ||
|
|
||
| <Form.Item | ||
| label={t("project.change.visible")} | ||
| required | ||
| name="visible" | ||
| valuePropName="checked" | ||
| > | ||
| <Switch onChange={handleVisibleChange} /> | ||
| </Form.Item> | ||
|
|
||
| {!isVisible && ( | ||
| <Form.Item | ||
| label={t("project.change.visibleAfter")} | ||
| name="visibleAfter" | ||
| > | ||
| <DatePicker | ||
| showTime | ||
|
There was a problem hiding this comment. Hier moet nog There was a problem hiding this comment. Ik heb het erbij gezet maar AllowClear is true by default |
||
| format="YYYY-MM-DD HH:mm:ss" | ||
| /> | ||
| </Form.Item> | ||
| )} | ||
|
|
||
| <Form.Item | ||
| label={t("project.change.maxScore")} | ||
| name="maxScore" | ||
| tooltip={t("project.change.maxScoreHelp")} | ||
| rules={[{ required: false, message: t("project.change.maxScoreMessage") }]} | ||
| > | ||
| <Input | ||
| min={1} | ||
| max={1000} | ||
| type="number" | ||
| /> | ||
| </Form.Item> | ||
|
|
||
| <Form.Item | ||
| label={t("project.change.deadline")} | ||
| name="deadline" | ||
| rules={[{ required: true }]} | ||
| > | ||
| <DatePicker | ||
| showTime | ||
| format="YYYY-MM-DD HH:mm:ss" | ||
| /> | ||
| </Form.Item> | ||
| </> | ||
| ) | ||
| } | ||
|
|
||
| export default GeneralFormTab | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ik denk dat het gemakkelijker is om dit te doen net voor je de POST/PUT request maakt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ik heb deze logica verplaatst naar de handleCreation functies van EditProject en ProjectCreate en de overbodige code uit GeneralFormTab verwijderd