Allow admin to submit #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In deze PR
Een course_admin kon nog geen submissions doen aangezien het hiervoor nodig was om in een groep te zitten. Nu kan dit wel.
Werking
Op het moment dat een submission gebeurt er geen group gevonden wordt voor de user wordt er gecheckt of deze een admin is, indien ja wordt het opgeslagen met
groupid=nullRoutes
Aangepast:
Overal waar een submissionjson wordt teruggegeven kunnen
groupIdengroupUrlnunullzijnToegevoegd:
Een route
/api/projects/{projectid}/adminsubmissionstoegevoegd om alle adminsubmission op te vragen voor een project. Response is van dezelfde vorm als/api/projects/{projectid}/submissions/{groupId}Disclaimer ❗
Testen moeten nog aangepast worden, en ik zou wachten op mergen totdat #263 gemerged is