added api routes instead of literal string

SELab-2 · Mar 9, 2024 · 567508b · 567508b
1 parent cf42a31
commit 567508b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/backend/app/src/main/java/com/ugent/pidgeon/controllers/ApiRoutes.java b/backend/app/src/main/java/com/ugent/pidgeon/controllers/ApiRoutes.java
@@ -3,4 +3,6 @@
 public final class ApiRoutes {
     public static final String USER_BASE_PATH = "/api/user/";
     public static final String COURSE_BASE_PATH = "/api/course/";
+
+    public static final String PROJECT_BASE_PATH = "/api/project/";
 }
diff --git a/backend/app/src/main/java/com/ugent/pidgeon/controllers/CourseController.java b/backend/app/src/main/java/com/ugent/pidgeon/controllers/CourseController.java
@@ -22,7 +22,7 @@ public class CourseController {
     @Autowired
     private TestRepository testRepository;
 
-    @GetMapping("/api/courses/{courseId}")
+    @GetMapping(ApiRoutes.COURSE_BASE_PATH + "{courseId}")
     @Roles({UserRole.teacher, UserRole.student})
     public ResponseEntity<List<ProjectEntity>> getProjectByCourseId(@PathVariable Long courseId) {
         List<ProjectEntity> projects = projectRepository.findByCourseId(courseId);

diff --git a/backend/app/src/main/java/com/ugent/pidgeon/controllers/ProjectController.java b/backend/app/src/main/java/com/ugent/pidgeon/controllers/ProjectController.java
@@ -26,7 +26,7 @@ public class ProjectController {
     @Autowired
     private TestRepository testRepository;
 
-    @GetMapping("/api/projects")
+    @GetMapping(ApiRoutes.PROJECT_BASE_PATH)
     @Roles({UserRole.teacher, UserRole.student})
     public ResponseEntity<?> getProjects() {
         List<ProjectEntity> allProjects = projectRepository.findAll();
@@ -42,7 +42,7 @@ public ResponseEntity<?> getProjects() {
         return ResponseEntity.ok().body(projectsWithUrls);
     }
 
-    @GetMapping("/api/projects/{projectId}")
+    @GetMapping(ApiRoutes.PROJECT_BASE_PATH + "{projectId}")
     @Roles({UserRole.teacher, UserRole.student})
     public ResponseEntity<?> getProjectById(@PathVariable Long projectId, Auth auth) {
         return projectRepository.findById(projectId)