Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create subjects page + Styling fixes subjects #227

Merged
merged 43 commits into from
May 21, 2024
Merged

Create subjects page + Styling fixes subjects #227

merged 43 commits into from
May 21, 2024

Conversation

mattiscauwel
Copy link
Contributor

@mattiscauwel mattiscauwel commented May 20, 2024 •
edited
Loading

Edit subject page

  • volledig functioneel

Subjects

Enkele styling aanpassingen aan subjects zoals:

  • Overflows van lange vaktitels, vakinstructors zijn scrollable op Subject page
  • Overflows van lange vaktitels, teveel vakkaartjes zijn scrollable op Subjects page
  • Handigere component voor het identificeren van Instructors
  • Instructors gesorteerd o.b.v. is_teacher en achternaam, zo staan professoren altijd vooraan

mattiscauwel added 30 commits May 18, 2024 15:37
@mattiscauwel
Merge remote-tracking branch 'origin/dev' into create_subject
c4eb449
@mattiscauwel
added router to create SubjectsView.vue
3e35231
@mattiscauwel
added first form elements
ac97ec7
@mattiscauwel
Merge branch 'subjects' into create_subject
ce8f2ca
@mattiscauwel
added submit button
a563492
@mattiscauwel
create subject via frontend works
c9171ed
@mattiscauwel
implemented search
ce713aa
@mattiscauwel
add users to instructors
b62cde6
@mattiscauwel
assign and delete users from instructors
3cc9c31
@mattiscauwel
sort instructors
2fac134
@mattiscauwel
begin styling create subject page
5da86fb
@mattiscauwel
more styling
e7d45c9
@mattiscauwel
adding instsructors
90c9428
@mattiscauwel
remove instructors
c25c746
@mattiscauwel
assign yourself button works
8344ed6
@mattiscauwel
emit cleanup
cdfd01a
@mattiscauwel
emitted events fixed
3affccc
@mattiscauwel
add instructors to db
9cd62a8
@mattiscauwel
form validation
6c45374
@mattiscauwel
implemented dialog
4e30a39
@mattiscauwel
added i18n
9e9c729
@mattiscauwel
Merge remote-tracking branch 'origin/dev' into create_subject
b8d9398
@mattiscauwel
i18n bug fixed
f2ce8e1
@mattiscauwel
styling details
c84a23c
@mattiscauwel
redirect after hitting confirm
643819f
@mattiscauwel
lint + format
b23d72f
@mattiscauwel
subjects overflow fix
e27f86e
@mattiscauwel
subject title card scrollable
3e5815b
@mattiscauwel
scrolling on overflow
041a594
@mattiscauwel
added v-chips and sorted instructors on subjectpage
587d478
@mattiscauwel mattiscauwel marked this pull request as draft May 20, 2024 10:29
@mattiscauwel
Copy link
Contributor Author

kleine rollback om styling conflicten met @masinnae te vermijden

@mattiscauwel mattiscauwel marked this pull request as ready for review May 20, 2024 11:02
@mattiscauwel mattiscauwel changed the title Styling fixes subjects Create subjects page + Styling fixes subjects May 20, 2024
masinnae
masinnae approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@masinnae masinnae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ziet er echt clean uit!

paar dingetjes van style die ik graag zou veranderen in de styling pr het mag van u:

  • sommige containers weghalen
  • zinnen niet capitalized zetten vb "Zoek Naar Vak Verantwoordelijken" veranderen naar "Zoek naar vakverantwoordelijken"

frontend/src/components/subject/createSubjectView/header/CreateSubjectHeaderCard.vue Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

de hint verwarde mij persoonlijk wat alsof ik iets fout aan het typen was door de "voer een geldige titel in"

reyniersbram
reyniersbram requested changes May 21, 2024
View reviewed changes
frontend/src/components/subject/subjectview/header/SubjectHeaderCard.vue
<v-card-title class="title">
{{ title }}
<div class="scrollable">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice dat dit scrollable is, maar niet echt duidelijk voor de gebruiker dat dit mogelijk is

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wordt gefixt door @masinnae normaal

frontend/src/components/subject/createSubjectView/header/CreateSubjectHeaderCard.vue Outdated Show resolved Hide resolved
frontend/src/components/subject/createSubjectView/body/UserSearchList.vue Show resolved Hide resolved
@mattiscauwel
Copy link
Contributor Author

  • mail optioneel toegevoegd
  • searchlist aangepast om later gebruik van throttle te voorzien

@mattiscauwel mattiscauwel merged commit 987a12e into dev May 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masinnae masinnae masinnae approved these changes

@reyniersbram reyniersbram reyniersbram approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattiscauwel @reyniersbram @masinnae