Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unmet file requirements op submitpagina #211

Merged
merged 23 commits into from
May 20, 2024
Merged

Unmet file requirements op submitpagina #211

merged 23 commits into from
May 20, 2024

Conversation

pieterjanin
Copy link
Contributor

@pieterjanin pieterjanin commented May 15, 2024 •
edited
Loading

Closes #168

  • Gebruiker krijgt te zien welke bestanden niet voldoen aan de bestandsvereisten als de indiening faalt.
  • Components van project/submission naar submission verplaatst
  • Vuetify 3.5 voor tooltips
  • FetchError wordt nu opgegooid in authorized_fetch ipv Error zodat we zelf kunnen kiezen wat we daar allemaal in steken.
  • Rare bug in useProjectGroupQuery

@pieterjanin pieterjanin added enhancement New feature or request frontend This is related to the frontend labels May 15, 2024
@pieterjanin pieterjanin added this to the Deadline 3 milestone May 15, 2024
@pieterjanin pieterjanin marked this pull request as ready for review May 18, 2024 00:29
@pieterjanin pieterjanin changed the title Submit file ext Unmet file requirements op submitpagina May 18, 2024
reyniersbram
reyniersbram approved these changes May 18, 2024
View reviewed changes
Copy link
Contributor

@reyniersbram reyniersbram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

frontend/tests/components/submission/SubmitForm.spec.ts Outdated Show resolved Hide resolved
frontend/tests/components/submission/SubmitCard.spec.ts Outdated Show resolved Hide resolved
pieterjanin and others added 3 commits May 19, 2024 00:11
@pieterjanin @reyniersbram
import
e9c53a5 
Co-authored-by: Bram Reyniers <[email protected]>
@pieterjanin @reyniersbram
import
83e4046 
Co-authored-by: Bram Reyniers <[email protected]>
@pieterjanin
Merge branch 'dev' into submit-file-ext
b0e54a0
@pieterjanin pieterjanin merged commit fd91c2c into dev May 20, 2024
4 checks passed
@pieterjanin pieterjanin deleted the submit-file-ext branch May 20, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyniersbram reyniersbram reyniersbram approved these changes

@xerbalind xerbalind xerbalind approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request frontend This is related to the frontend
Projects
None yet
Milestone
Deadline 3
Development

Successfully merging this pull request may close these issues.

Submit view: file extensions
3 participants
@pieterjanin @xerbalind @reyniersbram