Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom docker image tests #193

Merged
merged 21 commits into from
May 20, 2024
Merged

Custom docker image tests #193

merged 21 commits into from
May 20, 2024

Conversation

pieterjanin
Copy link
Contributor

Closes #189
Closes #139

  • Test files worden niet meer gemount in custom images, lesgevers moeten ze zelf kopiëren in de Dockerfile.
  • Docker crashes at runtime worden opgevangen, crashes at build time nog niet :/
  • Tests voor custom images en crashes at runtime.

@pieterjanin pieterjanin added bug Something isn't working backend This is related to the backend tests This is related to code testing labels May 11, 2024
@pieterjanin pieterjanin added this to the Deadline 3 milestone May 11, 2024
@pieterjanin
Copy link
Contributor Author

Test runners krijgen nu een label be.ugent.sel2-5:test_runner zodat ik gewoon alle gestopte containers met dat label kan wegdoen.

xerbalind
xerbalind reviewed May 20, 2024
View reviewed changes
Copy link
Contributor

@xerbalind xerbalind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pieterjanin pieterjanin merged commit d153df5 into dev May 20, 2024
4 checks passed
@pieterjanin pieterjanin deleted the custom-docker-tests branch May 20, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xerbalind xerbalind xerbalind left review comments

@reyniersbram reyniersbram reyniersbram approved these changes

Assignees
No one assigned
Labels
backend This is related to the backend bug Something isn't working tests This is related to code testing
Projects
None yet
Milestone
Deadline 3
3 participants
@pieterjanin @xerbalind @reyniersbram