Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix no projects found, more styling, filterbuttons #159

Merged
merged 2 commits into from
May 2, 2024
Merged

Conversation

miboelae
Copy link
Contributor

No description provided.

Copy link
Contributor

@xerbalind xerbalind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

</div>
</template>

<script setup lang="ts">
import { useProjectsQuery } from "@/queries/Project";
import ProjectMiniCard from "@/components/project/ProjectMiniCard.vue";
import {computed, ref, watch} from "vue";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

watch wordt nooit gebruikt

return projects.value.slice().filter((project: Project) => {
return new Date(project.deadline) < now;
});
case "notFinished":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in de toekomst hier ook projecten uitfilteren die al een submission hebben met status Accepted

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is da nodig? mss wil je nog nieuwe submission maken?

@xerbalind
Copy link
Contributor

nog eens npm run format uitvoeren zodat linter test slaagt

Copy link
Contributor

@DRIESASTER DRIESASTER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ziet er ait uit

return projects.value.slice().filter((project: Project) => {
return new Date(project.deadline) < now;
});
case "notFinished":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is da nodig? mss wil je nog nieuwe submission maken?

@miboelae miboelae merged commit 14dea74 into dev May 2, 2024
4 checks passed
@miboelae miboelae deleted the project_overview branch May 2, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants