create project page fixes #157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nieuwe alembic op db nodig (enkel op mijn db aangepast) |
miboelae
requested changes
May 3, 2024
miboelae
requested review from
xerbalind,
reyniersbram,
pieterjanin and
mattiscauwel
miboelae
approved these changes
May 8, 2024
xerbalind
requested changes
May 9, 2024
There was a problem hiding this comment.
publish_datedoet nog altijd niets, er wordt nog naaris_visibleipvpublish_date- wanneer het project aangemaakt is moet er geredirect worden naar de view. nu gebeurd er niets.
- nog i18n ontbreekt voor sommige tekst
- nog niet mogelijk om requirements toe te voegen
| const quillEditor = ref<typeof QuillEditor | null>(null); | ||
|
|
||
| watch(deadline, (newValue, oldValue) => { | ||
| console.log(`Deadline changed from ${oldValue.toISOString()} to ${newValue.toISOString()}`); |
There was a problem hiding this comment.
Enige reden voor al die console.log? mag van mij allemaal weg
There was a problem hiding this comment.
ja nee idd nie echt reden voor ma da deed ff funky en vergeten weghalen uit debug
Comment on lines
+1
to
+26
| """empty message | ||
|
|
||
| Revision ID: 1c4eb2b9d8da | ||
| Revises: 20886268d8b4, aa8ad1b4f8dc | ||
| Create Date: 2024-04-15 20:24:46.151762 | ||
|
|
||
| """ | ||
| from typing import Sequence, Union | ||
|
|
||
| from alembic import op | ||
| import sqlalchemy as sa | ||
|
|
||
|
|
||
| # revision identifiers, used by Alembic. | ||
| revision: str = '1c4eb2b9d8da' | ||
| down_revision: Union[str, None] = ('20886268d8b4', 'aa8ad1b4f8dc') | ||
| branch_labels: Union[str, Sequence[str], None] = None | ||
| depends_on: Union[str, Sequence[str], None] = None | ||
|
|
||
|
|
||
| def upgrade() -> None: | ||
| pass | ||
|
|
||
|
|
||
| def downgrade() -> None: | ||
| pass |
There was a problem hiding this comment.
Er zijn 7 alembic versions (allemaal) die niets doen -> mogen allemaal weg. Dus eig is er geen verandering in databank.
| :items="assistants" | ||
| description="Assign Assistants" | ||
| /> | ||
| <span v-else>No assistants found.</span> |
There was a problem hiding this comment.
hierboven staat al no instructors found wat is het verschil?
Comment on lines
+99
to
+100
| console.error("File upload failed", error); | ||
| alert("Could not upload files. Please try again."); |
There was a problem hiding this comment.
miss een vuetify alert ipv een alert box?
| } catch (error) { | ||
| console.error("Error during project or group creation:", error); | ||
| console.error("Error during project or group creation or file upload:", error); |
There was a problem hiding this comment.
hier ook een vuetify alert ipv in console
|
# Conflicts: # frontend/src/queries/Project.ts # frontend/src/services/project.ts
gdn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requested fixes finished