Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submission view #155

Merged
merged 6 commits into from
May 3, 2024
Merged

Submission view #155

merged 6 commits into from
May 3, 2024

Conversation

xerbalind
Copy link
Contributor

Closes #150

Bij een nieuwe indiening, kom je op nieuwe pagina met alle indieningen (en all de info) , met de nieuwe indiening bovenaan.
Zolang de nieuwste indiening InProgress is, wordt er om de seconde een refetch gedaan totdat deze Accepted is.

Indien er docker tests zijn uitgevoerd worden deze resultaten ook getoond.

Je kunt ook naar lijst van alle indieningen navigeren via project pagina.

Copy link

@Topvennie Topvennie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xerbalind working on the frontend 🤔
Good pr overall 👍

Comment on lines +48 to +55
const refetch_timer = () => {
setTimeout(() => {
const list = sorted.value;
if (list && list.length > 0 && list[0].status == 1) {
refetch();
refetch_timer();
}
}, 1000);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be cleaner with a websocket.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I respectfully disagree.

frontend/src/i18n/locales/nl.ts Show resolved Hide resolved
frontend/src/i18n/locales/nl.ts Show resolved Hide resolved
frontend/src/i18n/locales/nl.ts Show resolved Hide resolved
@xerbalind
Copy link
Contributor Author

@xerbalind working on the frontend 🤔 Good pr overall 👍

Hartelijk dank voor de review

Co-authored-by: Vincent Vallaeys <[email protected]>
Copy link
Contributor

@DRIESASTER DRIESASTER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ziet er in orde uit

color: red;
}

.Crashed {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol is purple de standaard voor crashed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nee? als je een andere kleur weet?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nee maakt nie uit hoor ben maar aant zeveren

Copy link
Contributor

@reyniersbram reyniersbram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ziet er snel snel gekeken wel ok uit

frontend/src/components/submission/SubmissionCard.vue Outdated Show resolved Hide resolved
@xerbalind xerbalind force-pushed the frontent_submission branch from cb3ab4a to 269ebae Compare May 3, 2024 11:59
@xerbalind xerbalind merged commit 6384e4e into dev May 3, 2024
4 checks passed
@xerbalind xerbalind deleted the frontent_submission branch May 3, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Submission view
4 participants