linting

SELab-2 · Mar 10, 2024 · efe61b0 · efe61b0
1 parent 7b74389
commit efe61b0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/backend/controllers/auth/authentication_controller.py b/backend/controllers/auth/authentication_controller.py
@@ -54,10 +54,10 @@ def parse_cas_xml(xml: str) -> dict | None:
                           .find(f"{namespace}attributes")
                           )
 
-        givenname: str = attributes_xml.find(f"{namespace}givenname")
+        givenname: str = attributes_xml.find(f"{namespace}givenname").text
         surname: str = attributes_xml.find(f"{namespace}surname").text
         email: str = attributes_xml.find(f"{namespace}mail").text
-        role: str = attributes_xml.findall(f"{namespace}objectClass")
+        role: str = attributes_xml.findall(f"{namespace}objectClass").text
 
         role_str: str = ""
         for r in role:

diff --git a/backend/tests/teachers_test.py b/backend/tests/teachers_test.py
@@ -15,7 +15,7 @@ def setUp(self) -> None:
     def test_create_teacher_bad_request(self) -> None:
         response = self.app.post("/teachers", data={})
         assert response.status_code == HTTPStatus.BAD_REQUEST
-        assert "error" in json.loads(response.data)
+        assert "error" in response.text
 
     def test_create_teacher_success(self) -> None:
         teacher_data = {"name": "Bart De Bruyn"}