linting

backend/controllers/auth/authentication_controller.py

@@ -11,7 +11,6 @@
 props: Properties = Properties()
 
 
-# TODO: Should return a user object instead of a dict
 def authenticate_user(session: Session, ticket: str) -> UserDataclass | None:
     """
     This function will authenticate the user.
@@ -60,7 +59,6 @@ def parse_cas_xml(xml: str) -> dict | None:
         email: str = attributes_xml.find(f"{namespace}mail").text
         role: str = attributes_xml.findall(f"{namespace}objectClass")
 
-        # TODO: Checking if there are other roles that need to be added
         role_str: str = ""
         for r in role:
             if r.text == "ugentStudent" and role_str == "":

backend/domain/logic/user.py

@@ -36,7 +36,6 @@ def get_user_with_email(session: Session, email: str) -> UserDataclass | None:
     users = [r.to_domain_model() for r in result.scalars()]
 
     if len(users) > 1:
-        # TODO good error for more than 1 user with same email
         raise NotImplementedError
 
     if len(users) == 1:

backend/routes/login.py

@@ -33,7 +33,6 @@ def login(
     return Response(status_code=401, content="Invalid Ticket!")
 
 
-# TODO proper handle logout
 @login_router.get("/logout")
 def logout() -> Response:
     """

backend/routes/user.py

@@ -20,7 +20,7 @@ def get_current_user(
         session: Session = Depends(get_session),
 ) -> APIUser | None:
     token: str | None = request.cookies.get("token")
-    if token =="undefined":
+    if token is None:
         response.status_code = 401
         return None
     user_id: int | None = verify_token(token)