chore: only run component build from preview middleware #2577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test
|
voicis
changed the title
vadson71
approved these changes
Nov 15, 2024
|
devinea
added a commit
that referenced
this pull request
Nov 15, 2024
* origin/main: (45 commits) chore: apply latest changesets Removes console log statement, adds some missing jsdoc (#2576) chore: only run component build from preview middleware (#2577) chore: apply latest changesets fix(ui-components): UITranslationInput. Screen readers read the resolved translation tooltip/title of UITranslationInput as part of the screen reader speech (#2568) fix: manifest changes not applied after reload (#2569) chore: apply latest changesets tbi(odata-service-inquirer): Move `ErrorHandler` and `getCFAbapInstanceChoices` to allow re-use (#2557) chore: apply latest changesets fix: adaptation editor crash (#2562) chore: apply latest changesets chore: update dependencies (#2558) chore: apply latest changesets fix(preview-middleware): typo (#2560) chore: apply latest changesets chore: enable quick actions (#2534) chore: apply latest changesets feat(cpe): display and write app descriptor changes for v4 (#2458) chore: apply latest changesets feat(@sap-ux/odata service inquirer): Adds system selection prompting (#2374) ...
devinea
added a commit
that referenced
this pull request
Nov 15, 2024
* origin/main: (54 commits) chore: apply latest changesets fix(cf-deploy-config-writer): cleanup based on local testing when using headless (#2546) chore: apply latest changesets Removes console log statement, adds some missing jsdoc (#2576) chore: only run component build from preview middleware (#2577) chore: apply latest changesets fix(ui-components): UITranslationInput. Screen readers read the resolved translation tooltip/title of UITranslationInput as part of the screen reader speech (#2568) fix: manifest changes not applied after reload (#2569) chore: apply latest changesets tbi(odata-service-inquirer): Move `ErrorHandler` and `getCFAbapInstanceChoices` to allow re-use (#2557) chore: apply latest changesets fix: adaptation editor crash (#2562) chore: apply latest changesets chore: update dependencies (#2558) chore: apply latest changesets fix(preview-middleware): typo (#2560) chore: apply latest changesets chore: enable quick actions (#2534) chore: apply latest changesets feat(cpe): display and write app descriptor changes for v4 (#2458) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After 8906662 build is failing because references from
@sap-ux-private/control-property-editor-commoncould not be resolved. We do not actually need to run type checking frompreview-middlewareas we only need to copy the artefacts over, so we can run only component build and relay on type checking being done bypreview-middleware-clientbuild.