Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle higher layer changes #2536

Merged
merged 26 commits into from
Nov 15, 2024
Merged

Conversation

GDamyanov
Copy link
Contributor

fix for #2535

  • Handle higher layer changes in CPE

@GDamyanov GDamyanov requested a review from a team as a code owner November 6, 2024 15:18
@GDamyanov GDamyanov self-assigned this Nov 6, 2024
Copy link

changeset-bot bot commented Nov 6, 2024

🦋 Changeset detected

Latest commit: dcc2669

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@sap-ux-private/preview-middleware-client Patch
@sap-ux/preview-middleware Patch
@sap-ux/create Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nikmace nikmace self-requested a review November 11, 2024 08:35
Copy link
Contributor

@heimwege heimwege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor finding and a question

packages/preview-middleware-client/src/flp/init.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@heimwege heimwege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Review comments addressed
  • test coverage is good
  • changeset ok
  • did NOT test locally

Copy link
Contributor

@nikmace nikmace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good
Coverage is alright
Did not test manually

Copy link
Contributor

@voicis voicis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Changes looks good
  • Review comments addressed
  • Good test coverage
  • Did not test

Copy link

sonarcloud bot commented Nov 15, 2024

@voicis voicis merged commit 1f7827c into main Nov 15, 2024
22 checks passed
@voicis voicis deleted the fix/2535/handle-higher-layer-changes branch November 15, 2024 16:50
devinea added a commit that referenced this pull request Nov 15, 2024
* origin/nx_updates_v2:
  chore: apply latest changesets
  fix: Handle higher layer changes (#2536)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants