Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(abap-deploy-config): update abap deploy config prompt options #2449

Merged
merged 10 commits into from
Oct 14, 2024

Conversation

cianmSAP
Copy link
Contributor

@cianmSAP cianmSAP commented Oct 9, 2024

#2442

Updates AbapDeployConfigPromptOptions to have prompt specific types

Copy link

changeset-bot bot commented Oct 9, 2024

🦋 Changeset detected

Latest commit: bca69d3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sap-ux/abap-deploy-config-inquirer Major
@sap-ux/create Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cianmSAP cianmSAP marked this pull request as ready for review October 10, 2024 10:43
@cianmSAP cianmSAP requested a review from a team as a code owner October 10, 2024 10:43
Copy link

sonarcloud bot commented Oct 11, 2024

Copy link
Contributor

@longieirl longieirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.
Test coverage is good.
Changeset is appropriate.
Sonar issues addressed.

Copy link
Contributor

@IainSAP IainSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cianmSAP

  • Improvements to align inquirer API options with other inquireres
  • Tests updates/added to cover

Copy link
Member

@unseen1980 unseen1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cianmSAP

The code looks good and the coverage is high 👍

@cianmSAP cianmSAP merged commit b3b1082 into main Oct 14, 2024
13 checks passed
@cianmSAP cianmSAP deleted the feat/2442/abap-deploy-config-inquirer-types branch October 14, 2024 09:58
devinea added a commit that referenced this pull request Oct 14, 2024
…r_check

* origin/cap_folder_check:
  chore: apply latest changesets
  feat(abap-deploy-config): update abap deploy config prompt options (#2449)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants