Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): shellbar redesign, add branding and additional context area #12694

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dpavlenishvili
Copy link
Contributor

@dpavlenishvili dpavlenishvili commented Nov 6, 2024

Related Issue(s)

closes #12520

Description

Implemented Shellbar ContextArea and integrated Shellbar Branding.

  • Added customizable branding section with logo, title, and subtitle via fd-shellbar-branding
  • Introduced fd-shellbar-context-area for additional elements like separator and spacer
  • Implemented fdShellbarHidePriority directive for custom overflow management with unique priority values
  • Enabled automatic priority assignment for context area elements based on placement order when fdShellbarHidePriority is omitted

Screenshots

Before:

After:

image

Please check whether the PR fulfills the following requirements

During Implementation
  1. Visual Testing:
  • visual misalignments/updates
  • check Light/Dark/HCB/HCW themes
  • RTL/LTR - proper rendering and labeling
  • responsiveness(resize)
  • Content Density (Cozy/Compact/(Condensed))
  • States - hover/disabled/focused/active/on click/selected/selected hover/press state
  • Interaction/Animation - open/close, expand/collapse, add/remove, check/uncheck
  • Mouse vs. Keyboard support
  • Text Truncation
  1. API and functional correctness
  • check for console logs (warnings, errors)
  • API boundary values
  • different combinations of components - free style
  • change the API values during testing
  1. Documentation and Example validations
  • missing API documentation or it is not understandable
  • poor examples
  • Stackblitz works for all examples
  1. Accessibility testing
  2. Browser Testing - Edge, Safari, Chrome, Firefox
PR Quality

@dpavlenishvili dpavlenishvili requested a review from a team November 6, 2024 12:03
@dpavlenishvili dpavlenishvili self-assigned this Nov 6, 2024
@dpavlenishvili dpavlenishvili linked an issue Nov 6, 2024 that may be closed by this pull request
2 tasks
Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit efd958d
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/673225e60349b100082b02c9
😎 Deploy Preview https://deploy-preview-12694--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Nov 6, 2024

Visit the preview URL for this PR (updated for commit efd958d):

https://fundamental-ngx-gh--pr12694-12520-shellbar-u73g9rxq.web.app

(expires Thu, 14 Nov 2024 15:47:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff

…usage of contex area, add unit tests and examples
…usage of contex area, add unit tests and examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UXC: shellbar updates
2 participants