Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move public-api-check script to GH action #5113

Merged
merged 45 commits into from
Nov 14, 2024

Conversation

shibeshduw
Copy link
Contributor

@shibeshduw shibeshduw commented Oct 23, 2024

The check public-api-script is converted to a GH action with inputs. This is then reused in the AI SDK (PR).
Closes https://github.tools.sap/AI/gen-ai-hub-sdk-js-backlog/issues/115

@shibeshduw shibeshduw marked this pull request as ready for review October 30, 2024 00:55
@shibeshduw
Copy link
Contributor Author

NOTE

Ignore the many junk commits. I couldn't get nektos/act to run actions locally on my machine, so I had to do some trial and error here.

The public api check works as intended both here and in the AI SDK.
The only problem here is with the unit tests for the public api check. This test case passes in one build/tests action but fails in the other two build/tests actions (see the checks above). According to the current logic, the current code is correct and the test should pass in every case. The issue arises with exportAllInBarrel() not identifying the barrelFile that has been mocked in the test.

Copy link
Contributor

@deekshas8 deekshas8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems existsSync doesn't work consistently between node 18 and 20/22.

build-packages/check-public-api/package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@deekshas8 deekshas8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shibeshduw shibeshduw merged commit 758fbbf into main Nov 14, 2024
16 checks passed
@shibeshduw shibeshduw deleted the public-api-check-gh-action branch November 14, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants