[READY] v2.x - Allow RubySaml::Utils.is_cert_expired and is_cert_active to accept an optional time argument
#733
+156
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnyshields
commented
Jan 11, 2025
| # @return [Integer] The new timestamp, after the duration is applied. | ||
| # | ||
| def parse_duration(duration, timestamp=Time.now.utc) | ||
| def parse_duration(duration, timestamp = Time.now) |
There was a problem hiding this comment.
Safe to do Time.now without .utc here because it's converted to UTC below.
…t an optional time argument.
… optional time argument
johnnyshields
force-pushed
the
v2.x-time-arg-to-utils
branch
from
a838600 to
2f0d6d3
Compare
johnnyshields
changed the title
RubySaml::Utils.is_cert_expired and is_cert_active to accept an optional time argumentRubySaml::Utils.is_cert_expired and is_cert_active to accept an optional time argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.