Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add texture validation #48

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add texture validation #48

wants to merge 1 commit into from

Conversation

S-S-X
Copy link
Owner

@S-S-X S-S-X commented Oct 27, 2021

Simple validation for textures, watches for node registration and checks if used textures exist.

To do:

  • Default excludes for core textures.
  • Proper texture definition parsing.
  • Good enough report for failed texture, it should be easy to find problem source lines based on report contents.
  • Move functionality away from core.lua, make it be new module that gets loaded based on configuration.
    • Consider multiple overrides for core registration functions, those might not be needed depending on how failures are handled.
  • Currently just prints error messages, allow failing tests after registrations are done:
    • Possibly after on_mods_loaded is executed.
    • Or after all tests have completed, this ensures that all registered nodes can be checked.
  • Allow handling node overrides by only looking for textures after tests have been executed.
    • Most probably it indicates problems if tests fail during registration but pass afterwards, probably not good.

@S-S-X S-S-X added enhancement New feature or request WIP Work in progress labels Oct 27, 2021
@S-S-X S-S-X marked this pull request as draft May 29, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant