Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update login method of twitter and nhentai. Add FAVORS_HOME env var. #64

Merged
merged 9 commits into from
Dec 4, 2024

Conversation

RyouMon
Copy link
Owner

@RyouMon RyouMon commented Dec 2, 2024

solove #52

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 97.44898% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.65%. Comparing base (ecd5f2d) to head (27e47cf).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
src/favorites_crawler/spiders/twitter.py 0.00% 3 Missing ⚠️
src/favorites_crawler/commands/crawl.py 33.33% 2 Missing ⚠️
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   75.50%   80.65%   +5.14%     
==========================================
  Files          35       37       +2     
  Lines        1188     1344     +156     
==========================================
+ Hits          897     1084     +187     
+ Misses        291      260      -31     
Files with missing lines Coverage Δ
src/favorites_crawler/commands/login.py 100.00% <100.00%> (+61.11%) ⬆️
src/favorites_crawler/constants/endpoints.py 100.00% <ø> (ø)
src/favorites_crawler/constants/path.py 100.00% <100.00%> (ø)
src/favorites_crawler/utils/auth.py 57.50% <100.00%> (+20.46%) ⬆️
src/favorites_crawler/utils/config.py 100.00% <100.00%> (ø)
tests/test_commands/test_login.py 100.00% <100.00%> (ø)
tests/test_utils/test_auth.py 100.00% <100.00%> (ø)
src/favorites_crawler/commands/crawl.py 69.56% <33.33%> (ø)
src/favorites_crawler/spiders/twitter.py 36.36% <0.00%> (-1.38%) ⬇️

@RyouMon RyouMon changed the title Update login method of twitter and nhentai Update login method of twitter and nhentai. Add FAVORS_HOME env var. Dec 3, 2024
@RyouMon RyouMon merged commit 29d2ad9 into main Dec 4, 2024
10 checks passed
@RyouMon RyouMon deleted the fix-login branch December 4, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant