Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support global config #62

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Support global config #62

merged 2 commits into from
Dec 2, 2024

Conversation

RyouMon
Copy link
Owner

@RyouMon RyouMon commented Dec 2, 2024

global config can apply to all spiders

global:
  ...
pixiv:
  ...

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 92.63158% with 7 lines in your changes missing coverage. Please review.

Project coverage is 75.50%. Comparing base (b422694) to head (e421690).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/favorites_crawler/commands/crawl.py 33.33% 4 Missing ⚠️
src/favorites_crawler/commands/login.py 0.00% 3 Missing ⚠️
@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
+ Coverage   73.92%   75.50%   +1.58%     
==========================================
  Files          34       35       +1     
  Lines        1112     1188      +76     
==========================================
+ Hits          822      897      +75     
- Misses        290      291       +1     
Files with missing lines Coverage Δ
src/favorites_crawler/utils/config.py 100.00% <100.00%> (+21.73%) ⬆️
tests/test_utils/test_config.py 100.00% <100.00%> (ø)
src/favorites_crawler/commands/login.py 38.88% <0.00%> (-2.29%) ⬇️
src/favorites_crawler/commands/crawl.py 69.56% <33.33%> (-4.86%) ⬇️

@RyouMon RyouMon merged commit 6e828df into main Dec 2, 2024
10 checks passed
@RyouMon RyouMon deleted the feature-global-config branch December 4, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant