#14 Fix placeholder #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyoNkmr
commented
Jun 26, 2018
| return document.querySelector(value) || fallback; | ||
|
|
||
| const element: ?HTMLElement = ([document.querySelector(value), ...fallbacks] | ||
| .find(item => !!item && item instanceof HTMLElement): any); |
There was a problem hiding this comment.
👀 Array.prototype.[filter|find] type refinement problem workaround
facebook/flow#1414 (comment)
😭
There was a problem hiding this comment.
get the power of Typescript 🙄
resessh
reviewed
Jun 26, 2018
| throw new Error('[Stuck.js] document.body is not HTMLElement in this environment'); | ||
| set wrapper(value: SelectorOrElement): void { | ||
| if (!(document.body instanceof HTMLElement)) { | ||
| throw new TypeError('[Stuck.js] document.body is not HTMLElement in this environment'); |
| @@ -1,11 +1,14 @@ | |||
| /* @flow */ | |||
| import Placeholder from './placeholder'; | |||
|
|
|||
| type MaybeHTMLElement = HTMLElement|Element|null|void; | |||
There was a problem hiding this comment.
why does this include void?
There was a problem hiding this comment.
Node.parentElement: ?Element;
https://github.com/facebook/flow/blob/v0.75.0/lib/dom.js#L439
that's why includes void
| return document.querySelector(value) || fallback; | ||
|
|
||
| const element: ?HTMLElement = ([document.querySelector(value), ...fallbacks] | ||
| .find(item => !!item && item instanceof HTMLElement): any); |
There was a problem hiding this comment.
get the power of Typescript 🙄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this closes #14
Changes
Before
After