Ros2 interface additions - extra suggestions #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Suggest minor changes for PR ArduPilot#6343.
Additional notes
I have some extra documentation on
tf
trees from my GSoC project, but since your PR is focused on documentingAP_DDS
I'm not sure if this is this wiki page is adequate for it, what do you think ? @Ryanf55A possible source of confusion regarding
tf
trees is thatardupilot_gz
launches end up creating two differenttf
trees.Theres the
ros_gz
/gz/tf
topic, which I tried to use in GSoC 2023 and failed due to it not following ROS REP 105:So, in order to have a working tree,
robot_state_publisher
was used to generate this REP 105 compliant tree:Which works perfectly when adding cartographer as a
map
->odom
->base_link
source.What worries me about putting this in the wiki is that
robot_state_publisher
depends on therobot_description
of each robot, so the picture might be misleading.