Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ros2 interface additions - extra suggestions #1

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

pedro-fuoco
Copy link

Purpose

Suggest minor changes for PR ArduPilot#6343.

Additional notes

I have some extra documentation on tf trees from my GSoC project, but since your PR is focused on documenting AP_DDS I'm not sure if this is this wiki page is adequate for it, what do you think ? @Ryanf55
A possible source of confusion regarding tf trees is that ardupilot_gz launches end up creating two different tf trees.

Theres the ros_gz /gz/tf topic, which I tried to use in GSoC 2023 and failed due to it not following ROS REP 105:
image

So, in order to have a working tree, robot_state_publisher was used to generate this REP 105 compliant tree:
image

Which works perfectly when adding cartographer as a map -> odom -> base_link source.
image

What worries me about putting this in the wiki is that robot_state_publisher depends on the robot_description of each robot, so the picture might be misleading.

@pedro-fuoco pedro-fuoco changed the title Ros2 interface additions -extra suggestions Ros2 interface additions - extra suggestions Nov 12, 2024
@Ryanf55 Ryanf55 merged commit 196be94 into Ryanf55:ros2-interface Nov 12, 2024
@Ryanf55
Copy link
Owner

Ryanf55 commented Nov 12, 2024

Wow, sorry, I never saw this till just now. Looks great. Yea, let's leave the complexify of how to make a working TF tree out for now. I'd like to amend the guides to show screenshots of the trees and how they get build on some of the specific use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants