Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing URLs and adding an imprint #23

Merged
merged 3 commits into from
Mar 17, 2020
Merged

Fixing URLs and adding an imprint #23

merged 3 commits into from
Mar 17, 2020

Conversation

badboy
Copy link
Member

@badboy badboy commented Mar 17, 2020

No description provided.

@badboy badboy requested a review from Kingdutch March 17, 2020 18:50
@djc
Copy link

djc commented Mar 17, 2020

LGTM.

@Kingdutch
Copy link
Contributor

@badboy Ah I see those policy pages don't actually exist yet. They're stuck in #20 which I believe needed review from/modification by @RafaelaWetzel

@badboy
Copy link
Member Author

badboy commented Mar 17, 2020

@Kingdutch I see. Let's get the CoC in though, it's linked from our blog.

@Kingdutch
Use Link for internal navigation
66f4361 
Using the Gatsby link element ensures that Gatsby can take over
navigation when JavaScript is enabled. We also add a wrapper and a
middot character to better group and separate the footer links.
@Kingdutch
Copy link
Contributor

@badboy My bad apparently the CoC and A11y statement were already put in separately :) The other PR only moved them around a bit. Not sure why it gave me a different diff and local experience just now.

Merging and deploying this :)

@Kingdutch Kingdutch merged commit 67fec02 into master Mar 17, 2020
@Kingdutch Kingdutch deleted the fixes branch March 17, 2020 19:22
@RafaelaWetzel
Copy link
Contributor

RafaelaWetzel commented Mar 18, 2020 •
edited
Loading

Quoting @flaki:

Another related thing I noticed, is that on our info page we refer (and link) to the PyCon attendee/staff reporting procedure. It is not ideal that we link to an external site and we should adopt and create our own policies for this based on the linked pages.

I've adapted the Attendee + Staff Procedure For Reporting Code of Conduct Incidents; will send it over on Zulip @Kingdutch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kingdutch Kingdutch Awaiting requested review from Kingdutch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@badboy @djc @Kingdutch @RafaelaWetzel