fixed issue #32 #88
Closed
fixed issue #32 #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corrected the remove function to handle the case where the user inputs a value that is not in the list into the function
bnmnetp
requested changes
Mar 12, 2020
wesleywu20
commented
Mar 12, 2020
|
Isn't this supposed to be one of the exercises? Or am I misunderstanding the PR? |
|
Good catch @codeofdusk -- Its been too long since I wrote this book, and a few years since I taught out of it. @wesleywu20 This is left out and is an exercise! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the code given for the implementation of the class UnorderedList in chapter 4.21 of the pythonds book does not handle the case where the user inputs a value that is not in the list into the function. However, this pull request corrects the remove function to handle that case.