Fix money_only_cents for negative money #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When given negative money, #money_only_cents does not return the expected subunit value due to how modulo handles negative numbers, for example: -125 % 100 = 75 To fix, updates calculation to use absolute value.
Co-authored-by: Sunny Ripert <[email protected]>
|
Thanks for the quick review, I've added the suggested improvement 👍🏽 |
semmons99
approved these changes
Mar 13, 2024
|
heads up. we have failing tests here. |
|
ignore. I removed 2.6/2.7 from testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why
When given negative money,
money_only_centsview helper does not return the expected subunit value due to how modulo handles negative numbers.For example: -125 % 100 = 75
What was done
To fix, I've updated the calculation to use the absolute value and added a new spec to cover the use case.