Fix monetized_attributes class discrepancy #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suppose we have a model
```ruby
class Investment < ActiveRecord::Base
monetize :value
monetize :discounted_value
end
```
and a subclass
```ruby
class BadInvestment < Investment
end
```
When we check the monetized_attributes of both the `Product` and `SpecialProduct` we get seemingly the same result:
```ruby
Investment.monetized_attributes
# => {
value: value_cents,
discounted_value: discounted_value_cents,
}
BadInvestment.monetized_attributes
# => {
value: value_cents,
discounted_value: discounted_value_cents,
}
```
...but when we check the class of the `monetized_attributes` we can see that one is a `ActiveSupport::HashWithIndifferentAccess` while the other is a `Hash`.
This commit fixes the discrepancy, ensuring both are a `ActiveSupport::HashWithIndifferentAccess`.
sunny
approved these changes
Nov 28, 2023
|
ty |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppose we have a model
and a subclass
When we check the monetized_attributes of both the
ProductandSpecialProductwe get seemingly the same result:...but when we check the class of the
monetized_attributeswe can see that one is aActiveSupport::HashWithIndifferentAccesswhile the other is aHash.This pull request fixes the discrepancy, ensuring both are a
ActiveSupport::HashWithIndifferentAccess.