Skip to content

Commit

Permalink
V2.2.8/http cache installation check should be nonfatal (#321)
Browse files Browse the repository at this point in the history
## Changelog

* HTTP Cache installation check should be non-fatal. (#320)
  • Loading branch information
orospakr authored Jan 18, 2019
1 parent 7059d99 commit 15debcb
Show file tree
Hide file tree
Showing 109 changed files with 480 additions and 40 deletions.
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,11 @@ block.
```groovy
dependencies {
// ...
implementation "io.rover:core:2.2.7"
implementation "io.rover:notifications:2.2.7"
implementation "io.rover:experiences:2.2.7"
implementation "io.rover:location:2.2.7"
implementation "io.rover:debug:2.2.7"
implementation "io.rover:core:2.2.8"
implementation "io.rover:notifications:2.2.8"
implementation "io.rover:experiences:2.2.8"
implementation "io.rover:location:2.2.8"
implementation "io.rover:debug:2.2.8"
}
```

Expand Down
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

buildscript {
// all of the modules of the SDK will use this version number.
ext.rover_sdk_version = '2.2.7'
ext.rover_sdk_version = '2.2.8'
ext.rover_sdk_version_code = 3

ext.kotlin_version = '1.2.51'
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/kotlin/io/rover/core/assets/FetchByHttp.kt
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ class ImageDownloader(
// them in the same LRU cache pool will mean that rotating through just a few
// large photos will cause the small payloads to be evicted even though their
// contribution to consumption of the cache is tiny.
throw AndroidHttpsUrlConnectionNetworkClient.missingCacheException()
AndroidHttpsUrlConnectionNetworkClient.emitMissingCacheWarning()
}

connection.apply {
Expand Down
11 changes: 6 additions & 5 deletions core/src/main/kotlin/io/rover/core/data/http/NetworkClient.kt
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ class AndroidHttpsUrlConnectionNetworkClient(
// them in the same LRU cache pool will mean that rotating through just a few
// large photos will cause the small payloads to be evicted even though their
// contribution to consumption of the cache is tiny.
throw missingCacheException()
emitMissingCacheWarning()
}

val requestBody = bodyData?.toByteArray(Charsets.UTF_8)?.asGzip()
Expand Down Expand Up @@ -175,10 +175,11 @@ class AndroidHttpsUrlConnectionNetworkClient(
}

@JvmStatic
internal fun missingCacheException(): RuntimeException {
return RuntimeException("An HTTPUrlConnection cache is not enabled.\n" +
"Please see the Rover documentation for Installation and Initialization of the Rover SDK: https://www.rover.io/docs/android/\n" +
"Consider calling Rover.installSaneGlobalHttpCache() in your Application.onCreate()")
internal fun emitMissingCacheWarning() {
log.e("An HTTPUrlConnection cache is not enabled.\n" +
"Please see the Rover documentation for Installation and Initialization of the Rover SDK: https://developer.rover.io/v2/android/\n" +
"Ensure you are calling Rover.installSaneGlobalHttpCache() before Rover.initialize().\n" +
"Currently installed cache appears to be: ${HttpResponseCache.getInstalled()}")
}
}

Expand Down
Binary file not shown.
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
74d3c4729a078ca4b18d363155c26774
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
db4d73fcec2edd2f0cdab620f7beaaf2aca92dd3
Binary file not shown.
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
ea22cac0a114bb67b7096f2d88b9f3cb
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
4ce0763b97017c095f7eb53b34391c81841b3bcd
Binary file not shown.
1 change: 1 addition & 0 deletions maven/io/rover/advertising/2.2.8/advertising-2.2.8.aar.md5
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
1c15422d275595d7f7b2047955409be5
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
c3f39c9ff0dacdbfff3741bd11de0ab9e79c1b46
57 changes: 57 additions & 0 deletions maven/io/rover/advertising/2.2.8/advertising-2.2.8.pom
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
<modelVersion>4.0.0</modelVersion>
<groupId>io.rover</groupId>
<artifactId>advertising</artifactId>
<version>2.2.8</version>
<packaging>aar</packaging>
<dependencies>
<dependency>
<groupId>com.android.support</groupId>
<artifactId>appcompat-v7</artifactId>
<version>27.1.1</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>com.android.support</groupId>
<artifactId>support-v4</artifactId>
<version>27.1.1</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>com.android.support</groupId>
<artifactId>recyclerview-v7</artifactId>
<version>27.1.1</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>com.android.support</groupId>
<artifactId>design</artifactId>
<version>27.1.1</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>com.android.support</groupId>
<artifactId>support-vector-drawable</artifactId>
<version>27.1.1</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>org.jetbrains.kotlin</groupId>
<artifactId>kotlin-stdlib-jdk7</artifactId>
<version>1.2.51</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>com.google.android.gms</groupId>
<artifactId>play-services-ads</artifactId>
<version>17.0.0</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>io.rover</groupId>
<artifactId>core</artifactId>
<version>2.2.8</version>
</dependency>
</dependencies>
</project>
1 change: 1 addition & 0 deletions maven/io/rover/advertising/2.2.8/advertising-2.2.8.pom.md5
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
3b1f00ce6b88d98ed9fb02f532f0ad5c
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
fd74069a812457f936391d5a7701fdc4ef794ade
5 changes: 3 additions & 2 deletions maven/io/rover/advertising/maven-metadata.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<groupId>io.rover</groupId>
<artifactId>advertising</artifactId>
<versioning>
<release>2.2.7</release>
<release>2.2.8</release>
<versions>
<version>2.2.0-beta2</version>
<version>2.2.0</version>
Expand All @@ -13,7 +13,8 @@
<version>2.2.4</version>
<version>2.2.6</version>
<version>2.2.7</version>
<version>2.2.8</version>
</versions>
<lastUpdated>20190109161055</lastUpdated>
<lastUpdated>20190118151330</lastUpdated>
</versioning>
</metadata>
2 changes: 1 addition & 1 deletion maven/io/rover/advertising/maven-metadata.xml.md5
Original file line number Diff line number Diff line change
@@ -1 +1 @@
507049835662154f24fedb22e1c948fe
7de534f5e0cfdb6f303203622b5e7ecd
2 changes: 1 addition & 1 deletion maven/io/rover/advertising/maven-metadata.xml.sha1
Original file line number Diff line number Diff line change
@@ -1 +1 @@
9b1e6ab8b681425af34832f7b3da7bc54d3aa8b3
8eea403c2cf4fa356d50352182b498952999de81
Binary file added maven/io/rover/core/2.2.8/core-2.2.8-javadoc.jar
Binary file not shown.
1 change: 1 addition & 0 deletions maven/io/rover/core/2.2.8/core-2.2.8-javadoc.jar.md5
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
5ad08c56efbb9bc17d2ac1a65047de83
1 change: 1 addition & 0 deletions maven/io/rover/core/2.2.8/core-2.2.8-javadoc.jar.sha1
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
45cae626919a3ff0e4ecbfcb68a08d6adec8b3a3
Binary file added maven/io/rover/core/2.2.8/core-2.2.8-sources.jar
Binary file not shown.
1 change: 1 addition & 0 deletions maven/io/rover/core/2.2.8/core-2.2.8-sources.jar.md5
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
a8316f1bf57c88d3d711f0103c511921
1 change: 1 addition & 0 deletions maven/io/rover/core/2.2.8/core-2.2.8-sources.jar.sha1
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
0f9e1b86217bcb42f7d8e9eb1d683db4ce5f5b68
Binary file added maven/io/rover/core/2.2.8/core-2.2.8.aar
Binary file not shown.
1 change: 1 addition & 0 deletions maven/io/rover/core/2.2.8/core-2.2.8.aar.md5
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
81277de7e5a888f9903bf5a8d0395582
1 change: 1 addition & 0 deletions maven/io/rover/core/2.2.8/core-2.2.8.aar.sha1
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
47263a2fb32b40ef56e10aefc28d623adb4b316a
64 changes: 64 additions & 0 deletions maven/io/rover/core/2.2.8/core-2.2.8.pom
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
<modelVersion>4.0.0</modelVersion>
<groupId>io.rover</groupId>
<artifactId>core</artifactId>
<version>2.2.8</version>
<packaging>aar</packaging>
<dependencies>
<dependency>
<groupId>org.jetbrains.kotlin</groupId>
<artifactId>kotlin-android-extensions-runtime</artifactId>
<version>1.2.51</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>com.android.support</groupId>
<artifactId>appcompat-v7</artifactId>
<version>27.1.1</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>com.android.support</groupId>
<artifactId>support-v4</artifactId>
<version>27.1.1</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>com.android.support</groupId>
<artifactId>transition</artifactId>
<version>27.1.1</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>com.android.support</groupId>
<artifactId>customtabs</artifactId>
<version>27.1.1</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>org.jetbrains.kotlin</groupId>
<artifactId>kotlin-stdlib-jdk7</artifactId>
<version>1.2.51</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>org.reactivestreams</groupId>
<artifactId>reactive-streams</artifactId>
<version>1.0.2</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>android.arch.lifecycle</groupId>
<artifactId>extensions</artifactId>
<version>1.1.1</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>android.arch.work</groupId>
<artifactId>work-runtime-ktx</artifactId>
<version>1.0.0-alpha10</version>
<scope>compile</scope>
</dependency>
</dependencies>
</project>
1 change: 1 addition & 0 deletions maven/io/rover/core/2.2.8/core-2.2.8.pom.md5
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
e9fc7ae4076c724206e70ab280b1bd72
1 change: 1 addition & 0 deletions maven/io/rover/core/2.2.8/core-2.2.8.pom.sha1
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
e195c7a1cd75f99f8c2b1049b1a65cd360532d77
5 changes: 3 additions & 2 deletions maven/io/rover/core/maven-metadata.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<groupId>io.rover</groupId>
<artifactId>core</artifactId>
<versioning>
<release>2.2.7</release>
<release>2.2.8</release>
<versions>
<version>2.0.0-beta.1-SNAPSHOT</version>
<version>2.0.0-beta.2-SNAPSHOT</version>
Expand All @@ -28,7 +28,8 @@
<version>2.2.5</version>
<version>2.2.6</version>
<version>2.2.7</version>
<version>2.2.8</version>
</versions>
<lastUpdated>20190109161022</lastUpdated>
<lastUpdated>20190118151246</lastUpdated>
</versioning>
</metadata>
2 changes: 1 addition & 1 deletion maven/io/rover/core/maven-metadata.xml.md5
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0c238eff3a4db75137118502d693f237
9f67bbbf166ee70b49f036ba249952d1
2 changes: 1 addition & 1 deletion maven/io/rover/core/maven-metadata.xml.sha1
Original file line number Diff line number Diff line change
@@ -1 +1 @@
5a325a4d620a8676aaa9e3ec3de645cf857beae6
01c5a93b06d226156ab50b02eb3109431c16a047
Binary file added maven/io/rover/debug/2.2.8/debug-2.2.8-javadoc.jar
Binary file not shown.
1 change: 1 addition & 0 deletions maven/io/rover/debug/2.2.8/debug-2.2.8-javadoc.jar.md5
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
36aa9cb1cd369de863f83d915c70ba24
1 change: 1 addition & 0 deletions maven/io/rover/debug/2.2.8/debug-2.2.8-javadoc.jar.sha1
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
2e9b1805b18b6b6b75ba833bcdd2963c80212c8c
Binary file not shown.
1 change: 1 addition & 0 deletions maven/io/rover/debug/2.2.8/debug-2.2.8-sources.jar.md5
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
618213d36e527353bb48f6f0d28f95cc
1 change: 1 addition & 0 deletions maven/io/rover/debug/2.2.8/debug-2.2.8-sources.jar.sha1
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
26f31edd144c3552fba93a62be9b861c1ac9a409
Binary file added maven/io/rover/debug/2.2.8/debug-2.2.8.aar
Binary file not shown.
1 change: 1 addition & 0 deletions maven/io/rover/debug/2.2.8/debug-2.2.8.aar.md5
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
da87d268981cf3ee437115a1af032810
1 change: 1 addition & 0 deletions maven/io/rover/debug/2.2.8/debug-2.2.8.aar.sha1
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
c01b6d21c03f24df05e8d1ec4c655b8ef04a7198
39 changes: 39 additions & 0 deletions maven/io/rover/debug/2.2.8/debug-2.2.8.pom
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
<modelVersion>4.0.0</modelVersion>
<groupId>io.rover</groupId>
<artifactId>debug</artifactId>
<version>2.2.8</version>
<packaging>aar</packaging>
<dependencies>
<dependency>
<groupId>com.android.support</groupId>
<artifactId>appcompat-v7</artifactId>
<version>27.1.1</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>com.android.support</groupId>
<artifactId>support-v4</artifactId>
<version>27.1.1</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>org.jetbrains.kotlin</groupId>
<artifactId>kotlin-stdlib-jdk7</artifactId>
<version>1.2.51</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>com.android.support</groupId>
<artifactId>preference-v7</artifactId>
<version>27.1.1</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>io.rover</groupId>
<artifactId>core</artifactId>
<version>2.2.8</version>
</dependency>
</dependencies>
</project>
1 change: 1 addition & 0 deletions maven/io/rover/debug/2.2.8/debug-2.2.8.pom.md5
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
8825a1e877498af6fbc5fe17ba206f2e
1 change: 1 addition & 0 deletions maven/io/rover/debug/2.2.8/debug-2.2.8.pom.sha1
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
7213c61032a25a7ddda5dfa2363bcba49eb53b5e
5 changes: 3 additions & 2 deletions maven/io/rover/debug/maven-metadata.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<groupId>io.rover</groupId>
<artifactId>debug</artifactId>
<versioning>
<release>2.2.7</release>
<release>2.2.8</release>
<versions>
<version>2.0.0-beta.1-SNAPSHOT</version>
<version>2.0.0-beta.2-SNAPSHOT</version>
Expand All @@ -28,7 +28,8 @@
<version>2.2.5</version>
<version>2.2.6</version>
<version>2.2.7</version>
<version>2.2.8</version>
</versions>
<lastUpdated>20190109161051</lastUpdated>
<lastUpdated>20190118151323</lastUpdated>
</versioning>
</metadata>
2 changes: 1 addition & 1 deletion maven/io/rover/debug/maven-metadata.xml.md5
Original file line number Diff line number Diff line change
@@ -1 +1 @@
06913f4f11e7e707064ae162ff23aac3
16da17d6fdf22effda18250bf946fe35
2 changes: 1 addition & 1 deletion maven/io/rover/debug/maven-metadata.xml.sha1
Original file line number Diff line number Diff line change
@@ -1 +1 @@
dd06fc8019676dc8754bf2ff40dd07624e8301d8
74f948d55979da8c9712c9a4f01822be160940ef
Binary file not shown.
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
1bc52444ca394e3e042ece6a72a160b0
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
ed316206b12f7068c6a19ea6f6869a5a3df13a1e
Binary file not shown.
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
c5d5e61e8e01dcffe2b7e1cefffddf70
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
345c7bd1dc16bd6eec77a3be3fa461905c0c07fb
Binary file not shown.
1 change: 1 addition & 0 deletions maven/io/rover/experiences/2.2.8/experiences-2.2.8.aar.md5
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
7af19604fd812cd46993abf99f396470
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
e8ca832b7adcd66f95db2f66c39032e04ca42c5b
Loading

0 comments on commit 15debcb

Please sign in to comment.