Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/classification #49

Draft
wants to merge 25 commits into
base: main
Choose a base branch
from
Draft

Feat/classification #49

wants to merge 25 commits into from

Conversation

adityajain07
Copy link
Contributor

No description provided.

@adityajain07 adityajain07 self-assigned this Nov 13, 2024
f-PLT
f-PLT reviewed Nov 15, 2024
View reviewed changes
Copy link
Contributor

@f-PLT f-PLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a first pass on this PR.

Overall, very good and it's nice to see the progress between PRs 😄

Comments are mostly suggestions to help you see other patterns when writing if/elif/else and how they can help with maintainability and reducing duplication.

src/classification/constants.py Show resolved Hide resolved
src/classification/dataloader.py Outdated Show resolved Hide resolved
src/classification/dataloader.py Outdated Show resolved Hide resolved
src/classification/dataloader.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-PLT f-PLT f-PLT left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@adityajain07 adityajain07

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adityajain07 @f-PLT