fix/backport compatibility issues for msvc 2019 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use _DISABLE_EXTENDED_ALIGNED_STORAGE to keep (nonstandard) alignment * use c++17 (mainly for std::filesystem, which is in fact not used in upstream any more) * use correct namespace for filesystem in c++17 * random_shuffle has changed in c++17, backport fix from upstream * some includes are checked more rigorously
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
this fix allows compilation with current (C++17 compliant) MS compilers. The goal was not to backport fixes from upstream (which reach the same goal) but to keep near the BSI-blessed version.
Background:
The most straight forward way to ensure that compiler- and platform-library-fixes (especially for security issues) is to ensure compatibility with current compilers.
Note: the impending roll-up, which is nearer to upstream will make this fix unnecessary. It should not be merged into this branch, if no pressing reasons emerge.