fix(Livechat): Popout mode not working in cross domains #33944
+33
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: a07a40c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33944 +/- ##
========================================
Coverage 75.19% 75.19%
========================================
Files 495 495
Lines 21601 21601
Branches 5362 5362
========================================
Hits 16242 16242
Misses 4717 4717
Partials 642 642
Flags with carried forward coverage won't be shown. Click here to find out more. |
MartinSchoeler
changed the title
MarcosSpessatto
requested changes
Nov 13, 2024
tiagoevanp
approved these changes
Nov 14, 2024
MarcosSpessatto
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Fixes issue that caused the
popoutmode of livechat to not work in cross domains situations, such as the rocketchat server being in one domain an the website that embedded livechat being in another. Operations between different domains are restricted so the localstorage never managed to actually sync between the two domains, creating different sessions when opening the popover viewI've changed the approach to sync the popout window with the server when opened using the livechat api call
setTokenin the popout window. After the popout is closed, when opening the normal widget again, it will sync with the server too, to get all the info of the popout session (new messages, dep/agent changes, etc...)Issue(s)
SUP-462